Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-11842 | Add PSC-XPN to cluster description #685

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

ckandag
Copy link
Collaborator

@ckandag ckandag commented Oct 23, 2024

OCM-11842

Adding PSC and XPN config paramaters to the cluster description

@ckandag ckandag changed the title Add PSC-XPN to cluster description OCM-11842 | Add PSC-XPN to cluster description Oct 23, 2024
@ckandag ckandag requested a review from renan-campos October 23, 2024 19:56
Signed-off-by: Chaitanya Kandagatla <[email protected]>
@renan-campos
Copy link
Collaborator

Sample output of the display changes would be a great aid to the review of these types of changes.

@renan-campos
Copy link
Collaborator

psc_describe.txt

non_psc_describe.txt

aws_describe.txt

@ckandag consider including output files like this next time.

Copy link
Collaborator

@renan-campos renan-campos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@renan-campos renan-campos merged commit 4053505 into openshift-online:main Oct 23, 2024
4 checks passed
ckandag added a commit that referenced this pull request Oct 25, 2024
-8b70707 Release v0.1.76 (#674)
-2ef1e1d Update Konflux references to 67f0290 (#676)
-c63247f Show all WIF configs in interactive dropdown (#677)
-f1d29bc adding interactive move for WifConfig creation (#675)
-1382a6c Require provider, do not default to AWS, and check for provider-specific flags (#678)
-d0b58b4 Do not default GCP authentication type (#679)
-db35759 improve psc cli UX (#681)
-862b072 OCM-11993 | Describe cluster shows WifConfig data (#683)
-4053505 Add PSC-XPN to cluster  description (#685)
-0c456f8 OCM-10728 | interface improvements (#686)
-1e27ded Add more descriptions to WIF resources (#684)
-cdf6466 update filenames in konflux release  container (#687)
-010573f remove version from shasum (#688)
@ckandag ckandag mentioned this pull request Oct 25, 2024
renan-campos pushed a commit that referenced this pull request Oct 25, 2024
-8b70707 Release v0.1.76 (#674)
-2ef1e1d Update Konflux references to 67f0290 (#676)
-c63247f Show all WIF configs in interactive dropdown (#677)
-f1d29bc adding interactive move for WifConfig creation (#675)
-1382a6c Require provider, do not default to AWS, and check for provider-specific flags (#678)
-d0b58b4 Do not default GCP authentication type (#679)
-db35759 improve psc cli UX (#681)
-862b072 OCM-11993 | Describe cluster shows WifConfig data (#683)
-4053505 Add PSC-XPN to cluster  description (#685)
-0c456f8 OCM-10728 | interface improvements (#686)
-1e27ded Add more descriptions to WIF resources (#684)
-cdf6466 update filenames in konflux release  container (#687)
-010573f remove version from shasum (#688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants