OCM-2373 | feat: Moved associated to GetRole function to common #15

den-rgb · 2023-10-16T14:38:41Z

PR changed to : #16

oriAdler · 2023-10-17T10:30:31Z

Checking the ROSA repo, and some files in this repo, it seems that our convention for go file name is snakeCase.
Reference https://medium.com/@kdnotes/golang-naming-rules-and-conventions-8efeecd23b68

pkg/ocm/validations/getRole.go

pkg/aws/validations/getRole.go

go.mod

den-rgb force-pushed the OCM-2373-b branch from 1e108cc to 51d4b35 Compare October 16, 2023 16:07

oriAdler reviewed Oct 17, 2023

View reviewed changes

pkg/ocm/validations/getRole.go Outdated Show resolved Hide resolved

pkg/aws/validations/getRole.go Outdated Show resolved Hide resolved

ciaranRoche reviewed Oct 17, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

den-rgb force-pushed the OCM-2373-b branch 3 times, most recently from d38fdc3 to 7304fb6 Compare October 17, 2023 12:08

OCM-2373 | feat: Moved get role associated functions to common lib

aa6f271

den-rgb force-pushed the OCM-2373-b branch from 7304fb6 to aa6f271 Compare October 17, 2023 12:14

den-rgb closed this Oct 17, 2023

Provide feedback