Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-6311 | feat: Migrate common code to ocm-common repo #36

Merged
merged 1 commit into from
Apr 12, 2024
Merged

OCM-6311 | feat: Migrate common code to ocm-common repo #36

merged 1 commit into from
Apr 12, 2024

Conversation

yingzhanredhat
Copy link
Contributor

No description provided.

@xueli181114
Copy link
Contributor

/assign @hunterkepley

ciaranRoche
ciaranRoche reviewed Apr 9, 2024
View reviewed changes
hunterkepley
hunterkepley reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@hunterkepley hunterkepley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM besides the 4 comments I left - sent to ROSA squad for further review / merge

@yingzhanredhat yingzhanredhat changed the title OCM-6311 Migrate common code to ocm-common repo OCM-6311 | Migrate common code to ocm-common repo Apr 10, 2024
@yingzhanredhat yingzhanredhat force-pushed the OCM-6311 branch 2 times, most recently from 2b65591 to ab2f695 Compare April 10, 2024 08:33
hunterkepley
hunterkepley reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@hunterkepley hunterkepley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after this

@yingzhanredhat yingzhanredhat changed the title OCM-6311 | Migrate common code to ocm-common repo OCM-6311 | Migrate: common code to ocm-common repo Apr 10, 2024
@yingzhanredhat yingzhanredhat changed the title OCM-6311 | Migrate: common code to ocm-common repo OCM-6311 | Migrate: common code to ocm-common repo Apr 11, 2024
@yingzhanredhat
Copy link
Contributor Author

@hunterkepley @ciaranRoche Would you help review it again?

ciaranRoche
ciaranRoche reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment and I think we are good to merge this

@ciaranRoche
Copy link
Collaborator

Commit message is failing
OCM-6311 | Add : Migrate common code to ocm-common repo -> OCM-6311 | Feat: Migrate common code to ocm-common repo

@yingzhanredhat yingzhanredhat changed the title OCM-6311 | Migrate: common code to ocm-common repo OCM-6311 | Feat: Migrate common code to ocm-common repo Apr 11, 2024
@yingzhanredhat
Copy link
Contributor Author

@ciaranRoche Updated it.

@hunterkepley
Copy link
Contributor

If we change Feat to feat it should pass the commit message check;

The lint is complaining about undefined gomock methods (Describe, etc) - maybe the go.mod isn't updated with gomock?

@yingzhanredhat yingzhanredhat changed the title OCM-6311 | Feat: Migrate common code to ocm-common repo OCM-6311 | feat: Migrate common code to ocm-common repo Apr 12, 2024
@ciaranRoche ciaranRoche merged commit 0cac2b2 into openshift-online:main Apr 12, 2024
5 checks passed
@OAharoni-RedHat OAharoni-RedHat mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunterkepley hunterkepley hunterkepley left review comments

@ciaranRoche ciaranRoche ciaranRoche left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yingzhanredhat @xueli181114 @ciaranRoche @hunterkepley