OCM-11855 | test: Create bastion with proxy #77
Conversation
jameszwang
force-pushed
the
ocm-11855
branch
2 times, most recently
from
5c8021c to
e91f849
Compare
pkg/test/vpc_client/bastion.go
Outdated
| return inst, nil | ||
| } | ||
|
|
||
| func (vpc *VPC) PrepareBastion(zone string) (*types.Instance, error) { | ||
| func (vpc *VPC) PrepareBastionProxy(zone string, cidrIp string) (*types.Instance, error) { |
There was a problem hiding this comment.
Did you run vpc.Clean? Can the proxy bastion be cleaned?
There was a problem hiding this comment.
Clean operation will be done in DestroyBastionProxy func. In DestroyBastionProxy, key pair/security group and public subnet will be destroyed, VPC will not be deleted since it may be depended by cluster.
There was a problem hiding this comment.
@jameszwang Please respond rather than just resolve it.
There was a problem hiding this comment.
Currently, bastion instance and Key pair will be cleaned in DestroyBastionProxy func.
pkg/test/vpc_client/bastion.go
Outdated
| return err | ||
| } | ||
|
|
||
| err = vpc.DeleteVPCSecurityGroups(true) |
There was a problem hiding this comment.
If there is already cluster proxy start up, I believe this step will fail. Can you have a try?
There was a problem hiding this comment.
Yes, deleting security group operation will be failed due to has a dependent object. In fact, deleting VPC subnet has same issue. DestroyBastionProxy func at here only can destroy resources which created in PrepareBastionProxy, it can not delete other resource not created by PrepareBastionProxy since they have dependent object.
There was a problem hiding this comment.
Why no updating here but resolved?
There was a problem hiding this comment.
Remove DeleteVPCSecurityGroup and DeleteVPCSubnets operation from DestroyBastionProxy func because they may be failed when have dependent object.
jameszwang
force-pushed
the
ocm-11855
branch
2 times, most recently
from
08249ae to
9ad5419
Compare
jameszwang
force-pushed
the
ocm-11855
branch
from
1de4d66 to
8f3bfde
Compare
|
/lgtm |
No description provided.