Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6448 | fix: Fix UX bugs with CLI #13

Merged
merged 1 commit into from
May 22, 2024
+8 −8
Merged

OCM-6448 | fix: Fix UX bugs with CLI #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cmd/rosa-support/create/proxy/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ var args struct {
availabilityZone string
imageID string
privateKeyPath string
keyPairName string
keyPairFilePath string
caFilePath string
}

Expand All @@ -25,7 +25,7 @@ var Cmd = &cobra.Command{
Short: "Create proxy",
Long: "Create proxy.",
Example: ` # Create a proxy
rosa-support create proxy --region us-east-2 --vpc-id <vpc id> --availability-zone <AZ> --ca-file <filepath> --keypair-name <name>`,
rosa-support create proxy --region us-east-2 --vpc-id <vpc id> --availability-zone <AZ> --ca-file <filepath> --keypair-filepath <path/filename>`,
Run: run,
}

Expand Down Expand Up @@ -70,11 +70,11 @@ func init() {
)

flags.StringVarP(
&args.keyPairName,
"keypair-name",
&args.keyPairFilePath,
"keypair-filepath",
"",
"",
"Stores key pair in the given path (required)",
"Exact filepath/filename of the keypair. Example: 'my-keys.pem' or '../foo/bar/my-keys.pem' (required)",
)

err := Cmd.MarkFlagRequired("vpc-id")
Expand All @@ -97,7 +97,7 @@ func init() {
logger.LogError(err.Error())
os.Exit(1)
}
err = Cmd.MarkFlagRequired("keypair-name")
err = Cmd.MarkFlagRequired("keypair-filepath")
if err != nil {
logger.LogError(err.Error())
os.Exit(1)
Expand All @@ -109,7 +109,7 @@ func run(cmd *cobra.Command, _ []string) {
if err != nil {
panic(err)
}
_, ip, ca, err := vpc.LaunchProxyInstance(args.imageID, args.availabilityZone, args.keyPairName)
_, ip, ca, err := vpc.LaunchProxyInstance(args.imageID, args.availabilityZone, args.keyPairFilePath)
if err != nil {
panic(err)
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/rosa-support/create/sg/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func init() {
&args.count,
"count",
"",
0,
1,
gdbranco marked this conversation as resolved.
Show resolved Hide resolved
"Additional number of security groups to be created for the vpc",
)
flags.StringVarP(
Expand Down
Loading