-
Notifications
You must be signed in to change notification settings - Fork 19
add ocm_cluster_rosa_classic data source to get cluster id/name, stat… #78
base: main
Are you sure you want to change the base?
add ocm_cluster_rosa_classic data source to get cluster id/name, stat… #78
Conversation
…e and version of existing cluster
@vamsinm this should be covered as part of terraform import command... |
@bardielle can you please elaborate? it does not make sense to run import command in to terraform state just to be able to lookup. any reservations why we can not have data source? |
"name": { | ||
Description: "Name of the cluster.", | ||
Type: types.StringType, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be also an optional attribute
"id": { | ||
Description: "Unique identifier of the cluster.", | ||
Type: types.StringType, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be also an optional attribute
return | ||
} | ||
|
||
func (s *ClusterRosaClassicDataSource) Read(ctx context.Context, request tfsdk.ReadDataSourceRequest, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All clusters have those attributes right? Any reason to call it RosaClassic?
Also, this is confusing I think something like ClusterStateDataSource might be more appropriate.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vamsinm, please open the PR in the new repository - https://github.com/terraform-redhat/terraform-provider-ocm
This repository soon would be archived
@vamsinm This repository is deprecated, please open the same PR in the new repository - https://github.com/terraform-redhat/terraform-provider-ocm |
add ocm_cluster_rosa_classic data source to get cluster id/name, state and version of existing cluster