Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve GitOps comment problem with push requests #1510

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

savitaashture
Copy link
Member

When a user adds a GitOps comment
to a push request targeting a branch other than
the main branch, the pipelinerun should not
execute for those instances where the target
branch is set to 'main.'

Signed-off-by: Savita Ashture [email protected]

Changes

Submitter Checklist

  • 📝 A good commit message is important for other reviewers to understand the context of your change. Please refer to How to Write a Git Commit Message for more details how to write beautiful commit messages. We rather have the commit message in the PR body and the commit message instead of an external website.
  • ♽ Run make test before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and do pre-commit install in the root of this repo).
  • ✨ We heavily rely on linters to get our code clean and consistent, please ensure that you have run make lint before submitting a PR. The markdownlint error can get usually fixed by running make fix-markdownlint (make sure it's installed first)
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

When a user adds a GitOps comment
to a push request targeting a branch other than
the main branch, the pipelinerun should not
execute for those instances where the target
branch is set to 'main.'

Signed-off-by: Savita Ashture <[email protected]>
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8859aff) 62.90% compared to head (8536065) 62.93%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
+ Coverage   62.90%   62.93%   +0.03%     
==========================================
  Files         130      130              
  Lines       10422    10420       -2     
==========================================
+ Hits         6556     6558       +2     
+ Misses       3345     3342       -3     
+ Partials      521      520       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piyush-garg
Copy link
Member

lgtm

@piyush-garg piyush-garg merged commit bd4ad2f into openshift-pipelines:main Nov 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants