Fixes to fetch latest crc version in github workflow #154
Conversation
Signed-off-by: PuneetPunamiya <[email protected]>
PuneetPunamiya
force-pushed
the
fetch-latest-crc-version
branch
from
93e5560 to
9266417
Compare
PuneetPunamiya
changed the title
| latest_version=$(git -c 'versionsort.suffix=-' ls-remote --tags --sort='v:refname' https://github.com/crc-org/crc \ | ||
| | tail -n1 \ | ||
| | sed 's/.*\///; s/\^{}//; s/^v//') | ||
|
|
||
| # Use the extracted version in the tar command | ||
| tar -xf crc-linux-amd64.tar.xz --directory /usr/local/bin --strip-components=1 "crc-linux-${latest_version}-amd64/crc" |
There was a problem hiding this comment.
We are doing that because even though it is latest, the binary has the version number in the tarball ?
There was a problem hiding this comment.
As we are building tekton-caches from konflux, should we invest on GH workflows ?
There was a problem hiding this comment.
We are doing that because even though it is latest, the binary has the version number in the tarball ?
@vdemeester Yes, the binary has the version inside the tarball
There was a problem hiding this comment.
As we are building tekton-caches from konflux, should we invest on GH workflows ?
@pramodbindal I'm sorry I did not get the context completely
There was a problem hiding this comment.
@PuneetPunamiya / @vdemeester
We are building all compoennts from konflux including tekton-caches.
so any kind of build/test/release related enhancements should be done there only.
There was a problem hiding this comment.
@pramodbindal not necessarily no. We use whatever works and depending on the constraints.
For example, we use konflux to be able to easily release it as part of the Red Hat OpenShift Pipelines operator — if we didn't integrate it with, we wouldn't probably use konflux here and only rely on GitHub workflows.
What we need to make sure is that it is relatively easily to switch from one CI to the other. For example, running e2e tests on crc or on another openshift instance should be a matter of a set of different arguments we pass to a script.
But in general, there is no reason to stick to only on CI system and do everything in it. Let's use what works best for what me need, and we can mix and match.
There was a problem hiding this comment.
@PuneetPunamiya can be done in a follow-up, but we might want to rename the workflow, to something like "e2e tests on CRC" or something 👼🏼
No description provided.