Skip to content

Commit

Permalink
Ignore istio version suffix used in the downstream builds (istio-ecos…
Browse files Browse the repository at this point in the history
…ystem#446)

The test is expecting to see the same version parsed from versions.yaml
and a version string returned by `pilot-discovery version`.
This is not the same in downstream builds as we use the `_ossm` suffix.

Signed-off-by: Filip Brychta <[email protected]>
  • Loading branch information
FilipB authored Oct 25, 2024
1 parent 2f18e52 commit 16c3e03
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests/e2e/util/common/e2e_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ var (
// - 1.22.2
// - 1.23.0-rc.1
// - 1.24-alpha.feabc1234
istiodVersionRegex = regexp.MustCompile(`Version:"([^"]*)"`)
// matching only the version before first '_' which is used in the downstream builds, e.g. "1.23.2_ossm_tp.2"
istiodVersionRegex = regexp.MustCompile(`Version:"([^"_]*)[^"]*"`)

k = kubectl.New()
)
Expand Down

0 comments on commit 16c3e03

Please sign in to comment.