Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/kustomize/api from 0.18.0 to 0.19.0 #596

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2025

Bumps sigs.k8s.io/kustomize/api from 0.18.0 to 0.19.0.

Release notes

Sourced from sigs.k8s.io/kustomize/api's releases.

api/v0.19.0

Announce

This release introduces a unified internal package version (v0.19.0) across the entire kustomize repository. ref. kubernetes-sigs/kustomize#5800

Chore

#5810: Better error message on undefined loader behavior.

Dependencies

#5825: Update to latest kube-opeapi to drop govalidator dependency #5830: downgrade go-difflib and go-spew to tagged releases #5837: Update kyaml to v0.19.0

cmd/config/v0.19.0

Caution

This release of cmd/config module skipped a few versions(v0.15.0 -> v0.19.0) to unify each pkg version in the kustomize repo. ref. kubernetes-sigs/kustomize#5800

Announce

This release introduces a unified internal package version (v0.19.0) across the entire kustomize repository.

Dependencies

#5825: Update to latest kube-opeapi to drop govalidator dependency #5830: downgrade go-difflib and go-spew to tagged releases #5837: Update kyaml to v0.19.0

kyaml/v0.19.0

Announce

This release introduces a unified internal package version (v0.19.0) across the entire kustomize repository. ref. kubernetes-sigs/kustomize#5800

Dependencies

#5825: Update to latest kube-opeapi to drop govalidator dependency #5830: downgrade go-difflib and go-spew to tagged releases

kyaml/v0.18.1

This is a patch release of kyaml that was created due to a defect in the release process. Please check https://github.com/kubernetes-sigs/kustomize/releases/tag/kyaml%2Fv0.18.0

Commits
  • b69e765 Merge pull request #5839 from koba1t/pinToCmdConfig
  • 8a51255 Update cmd/config to v0.19.0
  • ce667b7 Merge pull request #5837 from koba1t/pinToKyaml
  • 1b33db5 Update kyaml to v0.19.0
  • 880a7a0 add go work verification step for github actions (#5833)
  • 2867f35 downgrade go-difflib and go-spew to tagged releases (#5830)
  • 214aa2a Merge pull request #5823 from kubernetes-sigs/dependabot/go_modules/hack/gola...
  • 6f62ee7 build(deps): bump golang.org/x/crypto from 0.24.0 to 0.31.0 in /hack
  • fcc9537 Merge pull request #5825 from dims/update-to-latest-kube-api-to-drop-govalida...
  • 84e6594 Update golangci/golangci-lint to v1.56.2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [sigs.k8s.io/kustomize/api](https://github.com/kubernetes-sigs/kustomize) from 0.18.0 to 0.19.0.
- [Release notes](https://github.com/kubernetes-sigs/kustomize/releases)
- [Commits](kubernetes-sigs/kustomize@api/v0.18.0...api/v0.19.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/kustomize/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jan 20, 2025
@openshift-ci openshift-ci bot requested review from Tessg22 and xiaoyu74 January 20, 2025 01:03
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign dee-6777 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bmeng
Copy link
Contributor

bmeng commented Jan 20, 2025

/retest

@samanthajayasinghe
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 28, 2025

Sorry, only users with push access can use that command.

@samanthajayasinghe
Copy link
Contributor

/rebase

@samanthajayasinghe
Copy link
Contributor

/retest

1 similar comment
@xiaoyu74
Copy link
Contributor

xiaoyu74 commented Feb 3, 2025

/retest

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 8670773 link true /test images
ci/prow/coverage 8670773 link true /test coverage
ci/prow/lint 8670773 link true /test lint
ci/prow/build 8670773 link true /test build
ci/prow/test 8670773 link true /test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xiaoyu74
Copy link
Contributor

xiaoyu74 commented Feb 3, 2025

Can see we've retested several times but the CI is still failed, just checked the build logs:

# k8s.io/apimachinery/pkg/util/managedfields/internal
/go/pkg/mod/k8s.io/[email protected]/pkg/util/managedfields/internal/structuredmerge.go:56:4: unknown field IgnoredFields in struct literal of type merge.Updater
/go/pkg/mod/k8s.io/[email protected]/pkg/util/managedfields/internal/structuredmerge.go:73:4: unknown field IgnoredFields in struct literal of type merge.Updater
make: *** [Makefile:52: build] Error 1

Looks the bumping sigs.k8s.io/kustomize/api v0.19.0 is incompatible with the current k8s.io/apimachinery v0.30.3.

As the bump PR are created by dependabot, thinking we can close this PR and waiting for the newer version k8s.io/apimachinery v0.30.3 to be bumped for compatibility. cc: @bmeng @smarthall @samanthajayasinghe

@smarthall
Copy link
Contributor

Looks like this one has been known about upstream for a while kubernetes/apimachinery#185

@smarthall
Copy link
Contributor

thinking we can close this PR and waiting for the newer version

@xiaoyu74 Agreed, Looking through the release notes and the changelog there isn't anything that we really need at the moment, and no security implications.

@xiaoyu74
Copy link
Contributor

xiaoyu74 commented Feb 3, 2025

@openshift-ci openshift-ci bot closed this Feb 3, 2025
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

@xiaoyu74: Closed this PR.

In response to this:

/close

more context for the decision with team: https://redhat-internal.slack.com/archives/C0326L38PEH/p1738620588338759?thread_ts=1738620150.038609&cid=C0326L38PEH

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 3, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/sigs.k8s.io/kustomize/api-0.19.0 branch February 3, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants