Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA-1010: Add a new version of GetImplicitlyEnabledCapabilities #1133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Jan 7, 2025

Add a new version of GetImplicitlyEnabledCapabilities that is going to be lifted to library-go.

At the moment, we keep the function here temporarily to ensure it works for CVO.
We should also keep it in mind once it goes to library-go, the function should be also usable for oc-cli, e.g., the extract command.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2025

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 7, 2025
@openshift-ci openshift-ci bot requested review from DavidHurta and wking January 7, 2025 20:15
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign wking for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongkailiu hongkailiu force-pushed the new-GetImplicitlyEnabledCapabilities branch 3 times, most recently from fd5df0e to bb6b61b Compare January 7, 2025 21:22
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2025

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Add a new version of GetImplicitlyEnabledCapabilities that is going to be lifted to library-go.

At the moment, we keep it function here temporarily to ensure the signature of the function works for CVO.
We should also keep it in mind once it goes to library-go, the function should be also usable for oc-cli, e.g., the extract command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2025

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Add a new version of GetImplicitlyEnabledCapabilities that is going to be lifted to library-go.

At the moment, we keep it function here temporarily to ensure the function works for CVO.
We should also keep it in mind once it goes to library-go, the function should be also usable for oc-cli, e.g., the extract command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2025

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Add a new version of GetImplicitlyEnabledCapabilities that is going to be lifted to library-go.

At the moment, we keep the function here temporarily to ensure it works for CVO.
We should also keep it in mind once it goes to library-go, the function should be also usable for oc-cli, e.g., the extract command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu hongkailiu force-pushed the new-GetImplicitlyEnabledCapabilities branch from bb6b61b to eb37012 Compare January 14, 2025 01:05
Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift eb37012 link true /test e2e-hypershift
ci/prow/e2e-agnostic-operator eb37012 link true /test e2e-agnostic-operator
ci/prow/e2e-agnostic-ovn eb37012 link true /test e2e-agnostic-ovn
ci/prow/e2e-aws-ovn-techpreview eb37012 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-agnostic-ovn-upgrade-into-change eb37012 link true /test e2e-agnostic-ovn-upgrade-into-change
ci/prow/e2e-agnostic-ovn-upgrade-out-of-change eb37012 link true /test e2e-agnostic-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants