-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPEDGE-1345: feat: add arbiter node support for HA #939
base: master
Are you sure you want to change the base?
Conversation
94baddf
to
8f0a47f
Compare
8f0a47f
to
9e6bd74
Compare
9e6bd74
to
3f2b2ab
Compare
@eggfoobar: This pull request references OCPEDGE-1345 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3f2b2ab
to
415c0cc
Compare
Signed-off-by: ehila <[email protected]>
415c0cc
to
fee0db5
Compare
@eggfoobar: This pull request references OCPEDGE-1345 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
3 similar comments
/retest-required |
/retest-required |
/retest-required |
@eggfoobar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
Per EP: openshift/enhancements#1674
This PR bumps to the latest ocp/api to pull in the new control plane topology defined in the Arbiter EP. The
HighlyAvailableArbiter
is a new control plane topology that allows for 2 regular sized master nodes and 1 smaller arbiter node as part of the control plane, this PR adds the check so that HA is still respected when the control plane topology is set toHighlyAvailableArbiter