Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CBP(),DBP() to Marvell VSP #233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+527 −78
Open

Add CBP(),DBP() to Marvell VSP #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion internal/daemon/vendor-specific-plugins/marvell/00.daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ spec:
mountPropagation: Bidirectional
- name: proc
mountPath: /proc
- name: ovs-bin
mountPath: /usr/local/bin/
- name: ovs-db
mountPath: /usr/local/var/run/openvswitch/
volumes:
- name: mrvl-vsp-mount
hostPath:
Expand All @@ -52,4 +56,10 @@ spec:
path: /var/run/netns
- name: proc
hostPath:
path: /proc/
path: /proc/
- name: ovs-bin
hostPath:
path: /usr/local/bin/
- name: ovs-db
hostPath:
path: /usr/local/var/run/openvswitch/
41 changes: 41 additions & 0 deletions internal/daemon/vendor-specific-plugins/marvell/debug-dp/debugdp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
package DebugDP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment to this file what this is used for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example of adding other Data plane for marvell vsp in near future
as of now this can be used to debug all the API call to data plane as we are planning to packages ovs-dpdk data plane for now as a seperate pod.
currently this functionality(debug dp) can be helpful for debugging mrvl-vsp without data plane it is only dummping the info called from vsp.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sounds useful.

But could you plase add what you just said as a comment? Your comment on github here cannot be found tomorrow, when somebody reviews the code.

It is also not clear to me how to use this in practice. Could you elaborate and give a short usage example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thom311 sure i will add in comment.
Regarding usage.
we have a flag in vsp(right now just a const inside main.go future plan isto make it configurable during run time) to choose dataplane where one can opt "debug" to use this funcitonality and this will dump all the everything to dataplane from vsp.
can be used for debug purpose of vsp without having a data plane also


import (
"github.com/go-logr/logr"
ctrl "sigs.k8s.io/controller-runtime"
)

type DebugDP struct {
log logr.Logger
}

func NewDebugDP() *DebugDP {
return &DebugDP{
log: ctrl.Log.WithName("MarvellVSP:DebugDP"),
}
}

func (debugDP *DebugDP) AddPortToDataPlane(bridgeName string, portName string, vfPCIAddres string, isDPDK bool) error {
debugDP.log.Info("AddPortToBridge ", "bridgeName", bridgeName, "PortName", portName)
return nil
}

func (debugDP *DebugDP) DeletePortFromDataPlane(bridgeName string, portName string) error {
debugDP.log.Info("DeletePortFromBridge ", "bridgeName", bridgeName, "PortName", portName)
return nil

}

func (debugDP *DebugDP) InitDataPlane(bridgeName string) error {
debugDP.log.Info("Init Data plane", "bridgeName", bridgeName)
return nil
}

func (debugDP *DebugDP) ReadAllPortFromDataPlane(bridgeName string) (string, error) {
debugDP.log.Info("ReadAllPortFromBridge ", "bridgeName", bridgeName)
return "", nil
}
func (debugDP *DebugDP) DeleteDataplane(bridgeName string) error {
debugDP.log.Info("DeleteDataplane", "bridgeName", bridgeName)
return nil
}
Loading