Rename ocpcluster masters #236
Conversation
Signed-off-by: Balazs Nemeth <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test make-e2e-test |
1 similar comment
|
/test make-e2e-test |
|
/test make-test |
3 similar comments
|
/test make-test |
|
/test make-test |
|
/test make-test |
|
@vrindle can you make this pass? |
|
/test make-e2e-test |
|
/hold Waiting for @vrindle to make sure our ci runs the necessary tests automatically |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
|
@bn222: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -13,17 +13,17 @@ clusters: | |||
| builder_image: "wsfd-advnetlab-amp04.anl.eng.bos2.dc.redhat.com:5000/ocp/builder:rhel-9-golang-1.22-openshift-4.18" | |||
| base_image: "wsfd-advnetlab-amp04.anl.eng.bos2.dc.redhat.com:5000/ocp/4.18:base-rhel9" | |||
| masters: | |||
| - name: "nicmodecluster-master-1" | |||
| - name: "{{cluster_name}}-master-1" | |||
There was a problem hiding this comment.
Why is this change desirable?
If you run the same config on different clusters, it seems nicer if the nodes have the same names. Otherwise, the name depends on the cluster, and if you are familiar with the name on Cluster A, you have to first find how they are called on Cluster B.
The commit message should explain why this is desirable.
There was a problem hiding this comment.
nicmodecluster is a left-over that we forgot to clean up.
testing if CI works again