Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-43894: Avoids to collect frr.log for MetalLB #427

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from

Conversation

rh-fcristin
Copy link

Entire frr.log files collected by the gather_metallb can be huge in size (several GB) and in case of clusters with a lot of nodes the must-gather size can grow easily to an unreasonable size to be shared.
Part of the frr logs are already into the regular container logs, I believe that in case these logs are really needed for troubleshooting we can still ask for them.

I'm proposing here to remove the frr.log files collection from the gather_metallb script, this will drastically improve the size of the must-gather.

Entire frr.log files collected by the gather_metallb can be huge in size
(several GB) and in case of cluster with a lot of nodes the must-gather
size can grow easiliy to an unreasonable size.
This removes the collection of frr.logs files from the gather_metallb
script.
Copy link
Contributor

@RickJWagner RickJWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.
Looks good to me.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2024
@sferich888
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 19, 2024
@rh-fcristin rh-fcristin changed the title Avoids to collect frr.log for MetalLB OCPBUGS-43894: Avoids to collect frr.log for MetalLB Oct 28, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 28, 2024
@openshift-ci-robot
Copy link

@rh-fcristin: This pull request references Jira Issue OCPBUGS-43894, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Entire frr.log files collected by the gather_metallb can be huge in size (several GB) and in case of clusters with a lot of nodes the must-gather size can grow easily to an unreasonable size to be shared.
Part of the frr logs are already into the regular container logs, I believe that in case these logs are really needed for troubleshooting we can still ask for them.

I'm proposing here to remove the frr.log files collection from the gather_metallb script, this will drastically improve the size of the must-gather.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-fcristin rh-fcristin changed the base branch from master to release-4.14 October 28, 2024 16:55
@openshift-ci-robot
Copy link

@rh-fcristin: This pull request references Jira Issue OCPBUGS-43894, which is invalid:

  • expected the bug to target the "4.14.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-43894 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Entire frr.log files collected by the gather_metallb can be huge in size (several GB) and in case of clusters with a lot of nodes the must-gather size can grow easily to an unreasonable size to be shared.
Part of the frr logs are already into the regular container logs, I believe that in case these logs are really needed for troubleshooting we can still ask for them.

I'm proposing here to remove the frr.log files collection from the gather_metallb script, this will drastically improve the size of the must-gather.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-fcristin rh-fcristin changed the base branch from release-4.14 to release-4.17 October 28, 2024 16:56
@openshift-ci-robot
Copy link

@rh-fcristin: This pull request references Jira Issue OCPBUGS-43894, which is invalid:

  • expected the bug to target the "4.17.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-43894 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Entire frr.log files collected by the gather_metallb can be huge in size (several GB) and in case of clusters with a lot of nodes the must-gather size can grow easily to an unreasonable size to be shared.
Part of the frr logs are already into the regular container logs, I believe that in case these logs are really needed for troubleshooting we can still ask for them.

I'm proposing here to remove the frr.log files collection from the gather_metallb script, this will drastically improve the size of the must-gather.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fedepaol
Copy link
Member

thanks for filing this!

@fedepaol
Copy link
Member

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, rh-fcristin, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Nov 28, 2024
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

@rh-fcristin: This pull request references Jira Issue OCPBUGS-43894. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Entire frr.log files collected by the gather_metallb can be huge in size (several GB) and in case of clusters with a lot of nodes the must-gather size can grow easily to an unreasonable size to be shared.
Part of the frr logs are already into the regular container logs, I believe that in case these logs are really needed for troubleshooting we can still ask for them.

I'm proposing here to remove the frr.log files collection from the gather_metallb script, this will drastically improve the size of the must-gather.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-fcristin
Copy link
Author

/reopen

@openshift-ci openshift-ci bot reopened this Nov 28, 2024
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@rh-fcristin: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

@rh-fcristin: This pull request references Jira Issue OCPBUGS-43894, which is invalid:

  • expected the bug to target the "4.17.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-43894 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Entire frr.log files collected by the gather_metallb can be huge in size (several GB) and in case of clusters with a lot of nodes the must-gather size can grow easily to an unreasonable size to be shared.
Part of the frr logs are already into the regular container logs, I believe that in case these logs are really needed for troubleshooting we can still ask for them.

I'm proposing here to remove the frr.log files collection from the gather_metallb script, this will drastically improve the size of the must-gather.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fedepaol
Copy link
Member

/retest

Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@rh-fcristin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants