-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the dataMoverPrepareTimeout and resourceTimeout to the Node-Agent #1657
base: master
Are you sure you want to change the base?
Conversation
8d45879
to
7c6ccf7
Compare
…-Agent Fixes openshift#1368 Adds the following fields to the Node-Agent within the DPA: - dataMoverPrepareTimeout How long to wait for preparing a DataUpload/DataDownload. Default is 30 minutes. - resourceTimeout How long to wait for resource processes which are not covered by other specific timeout parameters. Default is 10 minutes. Signed-off-by: Michal Pryc <[email protected]>
/retest |
/test 4.19-e2e-test-aws |
/test unit-test |
@@ -403,6 +403,19 @@ func (r *DataProtectionApplicationReconciler) customizeNodeAgentDaemonset(ds *ap | |||
nodeAgentContainer.ImagePullPolicy = imagePullPolicy | |||
setContainerDefaults(nodeAgentContainer) | |||
|
|||
// append data mover prepare timeout and resource timeout to nodeAgent container args | |||
if !useResticConf { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think PR needs rebase, since I removed this var in here 9ce4670#diff-080fe4f6649a4b1692368f7a41402aa8c6217c4ad5e5f8afe572fdd87974f939
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rebase is needed
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mpryc: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add the dataMoverPrepareTimeout and resourceTimeout to the DPA's Node-Agent
Fixes #1368
Adds the following fields to the Node-Agent within the DPA:
Why the changes were made
To fix #1368
How to test the changes made
make tests
dataMoverPrepareTimeout
:dataMoverPrepareTimeout
: