Network policy form design 4.9 #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beanh66
requested review from
mceledonia,
matthewcarleton,
beaumorley and
bmignano
bmignano
reviewed
May 24, 2021
There was a problem hiding this comment.
Looking good, @andrew-ronaldson ! Just left a few questions and comments.
After review with Observability team we decided to remove the dropdown menus that started each "Allowed source" section. More helper text was added to simplify the process.
bmignano
approved these changes
Jun 22, 2021
Fixed inconsistency in working of delete actions and changes to Ports fields
itsptk
reviewed
Jul 1, 2021
|
|
||
|  | ||
|
|
||
| The ingress/egress rules are blocked into three categories of allowed peers: |
There was a problem hiding this comment.
It obviously seems like a deliberate decision but I was curious about the reason for using the term "peers" through the UI instead of the resource, like "pods?"
|
|
||
| The screenshot below shows all ingress and egress options in one view. | ||
|
|
||
|  |
There was a problem hiding this comment.
nit: Based on above images I think the link buttons would be "Add pod selector"
There was a problem hiding this comment.
Updating screenshots with a few other changes so I'll include the pod selector naming as well. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting Network policies is a critical part of the security of applications on a cluster. In OCP 4.7 the only way to manage Network policy in the console is to edit the yaml of these resources. It's a common and important enough operation that we should make this easier for administrators to work with. The goal of this work is to add the ability to create/update/delete NetworkPolicy resources through the OpenShift console in a way that is easier than directly editing the yaml representation of these resources.
@openshift/team-ux-leads
@openshift/team-ux-review (Administrator perspective)
@openshift/team-devconsole-ux (Developer perspective)
@openshift/team-kni-ux (KNI & Virtualization)