Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-23744: make context cmd quicker #578

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

Tof1973
Copy link
Contributor

@Tof1973 Tof1973 commented May 31, 2024

  • Some actions which were done in sequence are now done in parallel
  • We are now retrieving the cluster from OCM only one time in the process while it was done twice
  • before running the OCM query to retrieve cluster, we now detect first what is the cluster identifier, in order to make the query quicker
  • Add verbose output with delay for each action in order to be able to troubleshoot easily when command is taking time

With those changes we move from a frequent context of more than 10s (and sometime much more) to a context of less than 5s most of the time ;)

@openshift-ci openshift-ci bot requested review from dustman9000 and typeid May 31, 2024 12:42
@Tof1973 Tof1973 changed the title [OSD-23744] make context cmd quicker OSD-23744: make context cmd quicker May 31, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 31, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2024

@Tof1973: This pull request references OSD-23744 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

  • Some actions which were done in sequence are now done in parallel
  • We are now retrieving the cluster from OCM only once in the process while it was done twice
  • Add verbose output with delay for each action in order to be able to troubleshoot easily when command is taking time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2024

@Tof1973: This pull request references OSD-23744 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

  • Some actions which were done in sequence are now done in parallel
  • We are now retrieving the cluster from OCM only once in the process while it was done twice
  • Add verbose output with delay for each action in order to be able to troubleshoot easily when command is taking time

With those changes we move from a frequent context of more than 10s (and sometime much more) to a context of less than 5s most of the time ;)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2024

@Tof1973: This pull request references OSD-23744 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

  • Some actions which were done in sequence are now done in parallel
  • We are now retrieving the cluster from OCM only once in the process while it was done twice
  • before running the OCM query to retrieve cluster, we now detect first what is the cluster identifier, in order to make the query quicker
  • Add verbose output with delay for each action in order to be able to troubleshoot easily when command is taking time

With those changes we move from a frequent context of more than 10s (and sometime much more) to a context of less than 5s most of the time ;)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2024

@Tof1973: This pull request references OSD-23744 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

  • Some actions which were done in sequence are now done in parallel
  • We are now retrieving the cluster from OCM only one time in the process while it was done twice
  • before running the OCM query to retrieve cluster, we now detect first what is the cluster identifier, in order to make the query quicker
  • Add verbose output with delay for each action in order to be able to troubleshoot easily when command is taking time

With those changes we move from a frequent context of more than 10s (and sometime much more) to a context of less than 5s most of the time ;)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@AlexVulaj
Copy link
Contributor

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 31, 2024
@AlexVulaj
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, Tof1973

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

@Tof1973: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bdcc91a into openshift:master Jun 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants