Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] SDCICD-1418 add cmd option to promote operator saas through canary hives #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ritmun
Copy link
Contributor

@ritmun ritmun commented Dec 5, 2024

Adds canary promotion option to osd saas promotions. i.e;

osdctl promote saas --serviceName <service-name> --gitHash <git-hash> --osd  --canary=yes
  • Default value for canary is "auto". This promotes service to canary targets if they are set up in saas file. Otherwise proceeds with normal promotion.
  • Followup planned for saas file updates to be compatible with this option.

@openshift-ci openshift-ci bot requested review from sam-nguyen7 and Tafhim December 5, 2024 22:19
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ritmun
Once this PR has been reviewed and has the lgtm label, please assign dustman9000 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ritmun ritmun changed the title SDCICD-1418 add cmd option to promote operator saas through canary hives [wip] SDCICD-1418 add cmd option to promote operator saas through canary hives Dec 6, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2024
@ritmun ritmun force-pushed the canary branch 2 times, most recently from 9b743a6 to 754a7fe Compare December 6, 2024 18:45
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

@ritmun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant