Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding json values before sending #644

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smarthall
Copy link

Combined with the -i option this makes it possible to send a servicelog without using a template at all.

Solves: https://issues.redhat.com/browse/OSD-26164

@openshift-ci openshift-ci bot requested review from clcollins and typeid December 17, 2024 03:48
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smarthall
Once this PR has been reviewed and has the lgtm label, please assign dustman9000 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cmd/servicelog/post.go Outdated Show resolved Hide resolved
cmd/servicelog/post.go Show resolved Hide resolved
cmd/servicelog/post.go Show resolved Hide resolved
cmd/servicelog/post.go Outdated Show resolved Hide resolved
cmd/servicelog/post.go Outdated Show resolved Hide resolved
cmd/servicelog/common.go Outdated Show resolved Hide resolved
Combined with the `-i` option this makes it possible to send a
servicelog without using a template at all.
@smarthall smarthall force-pushed the override_json_values branch from 0624bf7 to 6d981fd Compare December 19, 2024 06:13
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@smarthall: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants