-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD-27572: Require a reason for using osdctl cluster ssh key
#646
OSD-27572: Require a reason for using osdctl cluster ssh key
#646
Conversation
/lgtm |
bb10460
to
67333b8
Compare
osdctl cluster ssh key
osdctl cluster ssh key
osdctl cluster ssh key
@joshbranham: This pull request references OSD-27572 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@joshbranham: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks Josh!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joshbranham, tnierman, typeid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I used this command and received a compliance ticket to fill out. This just plumbs one through via
osdctl cluster ssh key --elevation-reason $reason
. I made this flag required as well so you don't do the harder thing by default.I am going to update all the SOPs as well that don't reference this command to do so once this is released. Will link that PR here.