Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-27572: Require a reason for using osdctl cluster ssh key #646

Merged

Conversation

joshbranham
Copy link
Contributor

@joshbranham joshbranham commented Dec 20, 2024

I used this command and received a compliance ticket to fill out. This just plumbs one through via osdctl cluster ssh key --elevation-reason $reason. I made this flag required as well so you don't do the harder thing by default.

I am going to update all the SOPs as well that don't reference this command to do so once this is released. Will link that PR here.

> ./osdctl cluster ssh key --elevation-reason "#ITN-2024-00286" -S
Cluster:
	Name:	trbo-prod-cp-10
	ID:	2f785ugk0tgdjfovqkmc65dr1jn2d0st
	UUID:	0a1051d5-fb5f-44bd-8855-134fa08eace1

Continue? (y/N): y

INFO[0006] Backplane URL retrieved via OCM environment: https://api.backplane.openshift.com
INFO[0007] No PagerDuty API Key configuration available. This will result in failure of `ocm-backplane login --pd <incident-id>` command.
INFO[0009] Backplane URL retrieved via OCM environment: https://api.backplane.openshift.com
INFO[0009] No PagerDuty API Key configuration available. This will result in failure of `ocm-backplane login --pd <incident-id>` command.
-----BEGIN RSA PRIVATE KEY-----
.....

@openshift-ci openshift-ci bot requested review from sam-nguyen7 and typeid December 20, 2024 17:17
@tnierman
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@joshbranham joshbranham changed the title Require a reason for using 'osdctl cluster ssh key' Require a reason for using osdctl cluster ssh key Jan 6, 2025
@joshbranham joshbranham changed the title Require a reason for using osdctl cluster ssh key OSD-27572: Require a reason for using osdctl cluster ssh key Jan 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2025

@joshbranham: This pull request references OSD-27572 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

I used this command and received a compliance ticket to fill out. This just plumbs one through via osdctl cluster ssh key --elevation-reason $reason. I made this flag required as well so you don't do the harder thing by default.

I am going to update all the SOPs as well that don't reference this command to do so once this is released. Will link that PR here.

> ./osdctl cluster ssh key --elevation-reason "#ITN-2024-00286" -S
Cluster:
  Name:	trbo-prod-cp-10
  ID:	2f785ugk0tgdjfovqkmc65dr1jn2d0st
  UUID:	0a1051d5-fb5f-44bd-8855-134fa08eace1

Continue? (y/N): y

INFO[0006] Backplane URL retrieved via OCM environment: https://api.backplane.openshift.com
INFO[0007] No PagerDuty API Key configuration available. This will result in failure of `ocm-backplane login --pd <incident-id>` command.
INFO[0009] Backplane URL retrieved via OCM environment: https://api.backplane.openshift.com
INFO[0009] No PagerDuty API Key configuration available. This will result in failure of `ocm-backplane login --pd <incident-id>` command.
-----BEGIN RSA PRIVATE KEY-----
.....

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

@joshbranham: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@typeid typeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks Josh!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham, tnierman, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3d41376 into openshift:master Jan 7, 2025
5 checks passed
@joshbranham joshbranham deleted the update-sl-list-help branch January 7, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants