Adding support the CentOS based CoreOS images #503
Conversation
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
approved
| // TODO: This should hopefully only be temporary... | ||
| if m[4] == "92" { | ||
| return fmt.Sprintf("prod/streams/%s.%s-9.2", m[2], m[3]), true | ||
| } |
There was a problem hiding this comment.
This is gross and I hope it's only temporary...
@cgwalters and/or @jlebon Do you either of you know what the long term plan for how the release browser is going to handle new 9.2 CentOS based images?
There was a problem hiding this comment.
Ouch. I think we should probably figure out how to have this code have access to more information so it doesn't have to do this kind of guessing. Does it have access to the RHCOS container image labels? We could put the pipeline stream name the build came from in there.
There was a problem hiding this comment.
Yeah, embedding this information in the container image makes sense.
There was a problem hiding this comment.
This code is the thing nightmares are made of... the information we have is what we're parsing from the output of an oc adm release info --changelog command. 😢
There was a problem hiding this comment.
How hard would it be to change that? Can the code do another call to e.g. skopeo on the RHCOS image? Can the oc adm release info output be augmented to also output labels of the referred images?
OK, I see --includes-images which does work but it's super expensive because it's querying the metadata for all the images. Maybe simplest is to add an --include-image so then it can do --include-image rhel-coreos to only add the info for that one?
I also see annotations in the default output like this:
{
"name": "rhel-coreos-8",
"annotations": {
"io.openshift.build.commit.id": "",
"io.openshift.build.commit.ref": "",
"io.openshift.build.source-location": ""
},
"from": {
"kind": "DockerImage",
"name": "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:65f00f7a151a6a393f2d12a504f5ae14e1e7a249a35db23b0d053466d6469cad"
},
"generation": null,
"importPolicy": {},
"referencePolicy": {
"type": ""
}
},Not sure how those get there. They should be filled with info from https://github.com/openshift/os, but maybe we can also enhance it so it includes additional annotations.
There was a problem hiding this comment.
We could certainly add some logic to extract the information if/when it exists. Something like this should be sufficient and not too time consuming:
$ oc adm release info --image-for=rhel-coreos registry.ci.openshift.org/ocp/release:4.14.0-0.nightly-2023-03-08-194110
quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:cd299b2bf3cc98fb70907f152b4281633064fe33527b5d6a42ddc418ff00eec1
$ oc image info quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:cd299b2bf3cc98fb70907f152b4281633064fe33527b5d6a42ddc418ff00eec1
There was a problem hiding this comment.
Filed coreos/coreos-assembler#3390 for this.
|
/retest |
1 similar comment
|
/retest |
bradmwilliams
force-pushed
the
coreos-bump-fixes
branch
from
2514254
to
2663e07
Compare
|
@bradmwilliams: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradmwilliams, jupierce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.