-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-11043 | test: automated case id:76543 #2606
base: master
Are you sure you want to change the base?
Changes from 2 commits
2447c0d
04b34ec
01fd74d
8226df0
925f65b
20ae63d
5530ea9
e98578a
fe29b80
949afe0
54734e7
63bc0fe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,34 @@ profiles: | |
account-role: | ||
path: "/test/hcp/" | ||
permission_boundary: "arn:aws:iam::aws:policy/AdministratorAccess" | ||
- as: rosa-hcp-ze | ||
version: 4.14.38 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about other versions? we use latest version usually There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Currently, zero_egress is only supported for 4.14.y versions. Once the GA is released, I can change this to latest |
||
channel_group: stable | ||
region: "us-west-2" | ||
cluster: | ||
multi_az: true | ||
instance_type: "" | ||
hcp: true | ||
sts: true | ||
byo_vpc: true | ||
private: true | ||
additional_principals: false | ||
imdsv2: "" | ||
etcd_encryption: false | ||
autoscale: false | ||
kms_key: false | ||
oidc_config: "managed" | ||
networking: false | ||
proxy_enabled: false | ||
label_enabled: false | ||
tag_enabled: false | ||
zones: "" | ||
registries_config: true | ||
blocked_registries: true | ||
zero_egress: true | ||
account-role: | ||
path: "/test/hcp/" | ||
permission_boundary: "arn:aws:iam::aws:policy/AdministratorAccess" | ||
- as: rosa-hcp-upgrade-z-stream | ||
version: "z-1" | ||
channel_group: stable | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ import ( | |
"github.com/openshift/rosa/tests/utils/config" | ||
"github.com/openshift/rosa/tests/utils/constants" | ||
"github.com/openshift/rosa/tests/utils/exec/rosacli" | ||
"github.com/openshift/rosa/tests/utils/helper" | ||
"github.com/openshift/rosa/tests/utils/profilehandler" | ||
) | ||
|
||
|
@@ -657,4 +658,34 @@ var _ = Describe("HCP cluster testing", | |
} | ||
} | ||
}) | ||
|
||
It("create zero-egress HCP cluster - [id:76543]", | ||
labels.High, labels.Runtime.Day1, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it can move the step:CreateMachinePool in day2 case There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even though its part of the test case? I know that having a machinepool created on a ZE cluster was an area we wanted tested. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to the rule, we have day1\day2\destoy ... cases. We will filter the case by orde.So if the case is for day1, it would be better to not contain day2 step. We can move it in day2 case other than ignore the step. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No problem, I'll remove the mp portion. |
||
func() { | ||
By("Get cluster description") | ||
output, err := clusterService.DescribeCluster(clusterID) | ||
Expect(err).To(BeNil()) | ||
clusterDetail, err := clusterService.ReflectClusterDescription(output) | ||
Expect(err).To(BeNil()) | ||
Expect(clusterDetail.ZeroEgress).To(Equal("Enabled")) | ||
|
||
By("Create a machinepool describe it") | ||
mpID := helper.GenerateRandomName("mp-36293", 2) | ||
output, err = rosaClient.MachinePool.CreateMachinePool(clusterID, mpID, | ||
"--replicas", "1", | ||
"-y", | ||
) | ||
Expect(err).ToNot(HaveOccurred()) | ||
textData := rosaClient.Parser.TextData.Input(output).Parse().Tip() | ||
Expect(textData).To(ContainSubstring( | ||
"Machine pool '%s' created successfully on hosted cluster '%s'", | ||
mpID, | ||
clusterID)) | ||
_, err = machinePoolService.DescribeMachinePool(clusterID, mpID) | ||
Expect(err).ToNot(HaveOccurred()) | ||
defer func() { | ||
By("Remove the machine pool") | ||
rosaClient.MachinePool.DeleteMachinePool(clusterID, mpID) | ||
}() | ||
}) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this name:rosa-hcp-ze mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add zero_egress to exist profile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rosa-hcp-(zero egress)
I added it as a separate profile since there are restrictions about the version itself.