Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-13175 | fix: optional work role check for AmazonEC2ContainerRegistryReadOnly optional #2736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philipwu08
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from den-rgb and gdbranco December 18, 2024 21:33
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: philipwu08
Once this PR has been reviewed and has the lgtm label, please assign den-rgb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.11%. Comparing base (1d1ca9b) to head (2133993).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2736      +/-   ##
==========================================
- Coverage   29.11%   29.11%   -0.01%     
==========================================
  Files         185      185              
  Lines       25802    25805       +3     
==========================================
  Hits         7513     7513              
- Misses      17690    17693       +3     
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasponce
Copy link
Contributor

lucasponce commented Dec 19, 2024

Discussed with ROSA leads, to put on hold until we can define a common strategy.

cc @andreadecorte @robpblake @gdbranco

For context
https://redhat-internal.slack.com/archives/C0421HEGLSW/p1734559017656949

@robpblake
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2024
@philipwu08 philipwu08 force-pushed the skip-check-policy-ec2ContainerReg branch from f54c5e5 to 2133993 Compare December 20, 2024 04:47
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

@philipwu08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants