OCM-13218 | test: fix the failure of cluster provision and resource clean up #2739
Conversation
openshift-ci
bot
added
the
approved
xueli181114
force-pushed
the
OCM-12112
branch
2 times, most recently
from
71c3505 to
60118d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2739 +/- ##
=======================================
Coverage 29.11% 29.11%
=======================================
Files 185 185
Lines 25805 25805
=======================================
Hits 7513 7513
Misses 17693 17693
Partials 599 599 ☔ View full report in Codecov by Sentry. |
tests/utils/handler/interface.go
Outdated
| AuditLogArn string `json:"audit_log,omitempty"` | ||
| DNSDomain string `json:"dns_domain,omitempty"` | ||
| EtcdKMSKey string `json:"etcd_kms_key,omitempty"` | ||
| FromSharedAWSAccount *FromSharedAWSAccount `json:"from_shard_aws_account,omitempty"` |
There was a problem hiding this comment.
typo error from_shard_aws_account?
| ResourceShareArn string `json:"resource_share,omitempty"` | ||
| SharedVPCRole string `json:"shared_vpc_role,omitempty"` | ||
| VpcID string `json:"vpc_id,omitempty"` | ||
| } |
There was a problem hiding this comment.
Which resources are created by the regular AWS account, and which resources are created by the Shared AWS account, it is better to separate the resources created by the Shared AWS account in an individual block.
There was a problem hiding this comment.
That is a better resolution needs more research to see if any other place relied on the resources.json. How about make this merged to resolve the problem of resources leak which is affecting all CI jobs?
xueli181114
force-pushed
the
OCM-12112
branch
from
60118d5 to
b7c4f8e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xueli181114, yasun1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 06c25f5
into
openshift:master
No description provided.