Use swig4.2 or later #3985
Open
Use swig4.2 or later #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sure, will take a look. My guess is that the last argument is not currently
ever used by scripting users as the swig binding as of 4.1.1 was not usable
either.
…On Tue, Jan 7, 2025, 10:27 AM Nick Bianco ***@***.***> wrote:
Is there a chance the function in MocoUtilities is actually used? Should
we remove it altogether from bindings?
createPeriodicTrajectory() is quite frequently used by Moco users. Could
we add a custom SWIG binding for std::vector<std::pair<std::string,
std::string>> (e.g., StdVectorStringPair)?
—
Reply to this email directly, view it on GitHub
<#3985 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6JY4B5OTUCWRUCZRH2LX32JQMABAVCNFSM6AAAAABUYF2GBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZVHE3DINZYGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…tePeriodicTrajectory
undo formatting changes for non-swig side for cleaner diff
|
@nickbianco ready for review, I separated the prototypes so the code looks cleaner, there's no loss of functionality as the vector was never possible to construct in scripting. I can open a separate issue for that if you think we should keep it on our radar. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #0
Brief summary of changes
Changed CMakeLists to not require exact version match and SWIG out references to functions that are not useful to scripting
Testing I've completed
Looking for feedback on...
Is there a chance the function in MocoUtilities is actually used? Should we remove it altogether from bindings?
CHANGELOG.md (choose one)
This change is