Update bindings #1464
Closed
Update bindings #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickbianco For your review. Typically we only see a few file changes due to added/removed methods in the API, this time we got a ton of new files with prefix SWIGTYPE_p_* which are just clutter and typically pollute the bindings with unusable classes. Historically this happens when we change the ordering of include files. Wanted to bounce this off you since the last change before this with refactoring Geometry Path and it didn't have this side-effect. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #0
Brief summary of changes
Testing I've completed
CHANGELOG.md (choose one)