Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility noncurrentmdl #1490

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Fix visibility noncurrentmdl #1490

merged 2 commits into from
Feb 26, 2024

Conversation

aymanhab
Copy link
Member

Fixes issue #1487

Brief summary of changes

When object is selected from navigator, trace it back to owner model to affect visibility change rather than use the current model

Testing I've completed

tested scenario in issue and it was fixed.

CHANGELOG.md (choose one)

Will update after testing the artifact before merging

  • updated...

@aymanhab
Copy link
Member Author

@AlbertoCasasOrtiz for your review or @carmichaelong to review/test.

Copy link
Contributor

@AlbertoCasasOrtiz AlbertoCasasOrtiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on Windows 11 by hiding/showing markers individually on the non-selected model, and then all of them at once.

@aymanhab
Copy link
Member Author

Thanks @AlbertoCasasOrtiz 👍

@aymanhab aymanhab merged commit 03d3ad7 into main Feb 26, 2024
3 checks passed
@aymanhab aymanhab deleted the fix_visibility_noncurrentmdl branch February 26, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants