Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle property name change from GeometryPath to path in visualization #1495

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Handle property name change from GeometryPath to path in visualization #1495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5766be7
Handle property name change from GeometryPath to path in visualization
aymanhab Mar 10, 2024
4176e39
Update CHANGELOG.md
aymanhab Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ GitHub issues or pull requests that
are related to the items below. If there is no issue or pull
request related to the change, then we may provide the commit.

v4.6
======
- Fix issue [#1494](https://github.com/opensim-org/opensim-gui/issues/1494): Changing muscle path color throws exception.

v4.5
======
- Fix issue [#1378](https://github.com/opensim-org/opensim-gui/issues/1378): In Static Optimization Tool, dialog box has wrong title for "Directory" in output section.
Expand Down
2 changes: 1 addition & 1 deletion Gui/opensim/view/src/org/opensim/threejs/ModelVisualizationJson.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,7 +1407,7 @@ public void propagateGeometryPathCommandsToPathPoints(Force force, AbstractPrope
else {
JSONObject pathpointCommand = (JSONObject) lastCommand.clone();
if (force.hasVisualPath()){
GeometryPath gPath = GeometryPath.safeDownCast(force.getPropertyByName("GeometryPath").getValueAsObject());
GeometryPath gPath = GeometryPath.safeDownCast(force.getPropertyByName("path").getValueAsObject());

pathpointCommand.put("objectUuid", getFirstPathPointUUID4GeometryPath(gPath).toString());
commands.add(pathpointCommand);
Expand Down
Loading