Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visualization of pathpoints defined wrt offset frames #1518

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix visualization of pathpoints defined wrt offset frames #1518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
628eaea
Fix visualization of pathpoints defined wrt offset frames
aymanhab Aug 30, 2024
ca9d03c
Update CHANGELOG.md
aymanhab Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ v4.6
======
- Fix issue [#1494](https://github.com/opensim-org/opensim-gui/issues/1494): Changing muscle path color throws exception.
- Fix issue [#1493](https://github.com/opensim-org/opensim-gui/issues/1493): Rotating experimental data fails or results an unusable file.
- Fix issue [#1516](https://github.com/opensim-org/opensim-gui/issues/1516): Chains of Physical offset frames ignored when displaying GeometryPath

v4.5
======
Expand Down
10 changes: 9 additions & 1 deletion Gui/opensim/view/src/org/opensim/threejs/ModelVisualizationJson.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1602,7 +1602,15 @@ public JSONObject createPathPointObjectJson(AbstractPathPoint pathPoint, boolean
Transform localTransform = new Transform();
if (active && pathPoint!= null){
Vec3 location = pathPoint.getLocation(state);
localTransform.setP(location);
Frame parentFrame = pathPoint.getParentFrame();
Frame baseFrame = parentFrame.findBaseFrame();
if (baseFrame.equals(parentFrame))
localTransform.setP(location);
else {
// transform location to baseFrame as the scene graph for visualization uses it for mobodyindex
Vec3 locationInBaseFrame = parentFrame.findStationLocationInAnotherFrame(state, location, baseFrame);
localTransform.setP(locationInBaseFrame);
}
}
else
localTransform.setP(computedLocation);
Expand Down