Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openubmc新增搜索反馈 #281

Merged
merged 1 commit into from
Dec 11, 2024
Merged

openubmc新增搜索反馈 #281

merged 1 commit into from
Dec 11, 2024

Conversation

2511689622
Copy link
Collaborator

No description provided.

@shishupei
Copy link

开始门禁检查,等门禁检查通过后可以合入

@shishupei
Copy link

检查项 状态 日志
DT覆盖率 2.10756% 查看日志
Check代码检查 查看日志
敏感信息扫描 查看日志
安全编码扫描 查看日志
流水线链接 点击跳转

@@ -21,7 +21,7 @@
import com.datastat.model.HmsExportDataReq;
import com.datastat.model.IsvCount;
import com.datastat.model.NpsBody;
import com.datastat.model.QaBotRequestBody;
import com.datastat.model.OpenUbmcSearchNps;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QaBotRequestBody 删除后是否有影响

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无影响,这个没有使用过,在vscode中被标注出来了

@@ -0,0 +1,19 @@
package com.datastat.model;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请添加 copy right

@shishupei
Copy link

开始门禁检查,等门禁检查通过后可以合入

@shishupei
Copy link

检查项 状态 日志
DT覆盖率 2.10756% 查看日志
Check代码检查 查看日志
敏感信息扫描 查看日志
安全编码扫描 查看日志
流水线链接 点击跳转

@zhongjun2 zhongjun2 merged commit 4f50cff into develop_test Dec 11, 2024
4 of 5 checks passed
BulkRequest request = new BulkRequest();
RestHighLevelClient restHighLevelClient = getRestHighLevelClient();
IndexRequest indexRequest = new IndexRequest(queryConf.getOpenubmcSearchNpsIndex());
String s = queryConf.getOpenubmcSearchNpsIndex();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

未使用的变量

return ResultUtil.resultJsonStr(400, null, "error");
}
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

功能类似,可以考虑代码重用

IMPLIED, INCLUDING BUT NOT LIMITED TO NON-INFRINGEMENT, MERCHANTABILITY OR FIT FOR A PARTICULAR
PURPOSE.
See the Mulan PSL v2 for more details.
Create: 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

日期错误

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants