Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge the communication between FCT and FHIRCore app #3556

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

syedowaisali
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@syedowaisali syedowaisali requested a review from ellykits October 11, 2024 09:17
@syedowaisali syedowaisali marked this pull request as draft October 11, 2024 09:17
@syedowaisali syedowaisali added the DNM DO NOT MERGE label Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.2%. Comparing base (f2b8910) to head (436c00f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3556     +/-   ##
=========================================
- Coverage     38.9%   29.2%   -9.7%     
+ Complexity    1159     788    -371     
=========================================
  Files          284     282      -2     
  Lines        15060   13789   -1271     
  Branches      2669    2467    -202     
=========================================
- Hits          5860    4034   -1826     
- Misses        8356    9220    +864     
+ Partials       844     535    -309     
Flag Coverage Δ
engine 62.5% <ø> (-0.1%) ⬇️
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 72 files with indirect coverage changes

@syedowaisali
Copy link
Collaborator Author

$lite workflow dependency removed. cc: @ellykits

@dubdabasoduba
Copy link
Member

$lite workflow dependency removed. cc: @ellykits

@ellykits why did we remove $lite

@ellykits ellykits self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants