-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling sync status by harmonizing SDK and custom sync statuses #3650
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3650 +/- ##
=========================================
- Coverage 38.5% 38.3% -0.2%
- Complexity 1164 1166 +2
=========================================
Files 286 286
Lines 15232 15317 +85
Branches 2683 2699 +16
=========================================
+ Hits 5866 5875 +9
- Misses 8521 8596 +75
- Partials 845 846 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Lentumunai-Mark <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! can you please cover the new code paths with tests, thank you!
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes [link to issue]
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file