Practitioner Details implementation #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #890 +/- ##
============================================
- Coverage 52.20% 52.10% -0.10%
+ Complexity 659 656 -3
============================================
Files 192 194 +2
Lines 6798 6859 +61
Branches 1216 1225 +9
============================================
+ Hits 3549 3574 +25
- Misses 2647 2688 +41
+ Partials 602 597 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- Update LoginViewModel.kt to accommodate runOneTimeSync method - Update UserResponse.kt to accommodate all fields of getUserInfo call. - Add sample_practitioner_payload
# Conflicts: # android/engine/src/main/java/org/smartregister/fhircore/engine/ui/login/LoginViewModel.kt
# Conflicts: # android/engine/src/test/java/org/smartregister/fhircore/engine/ui/login/LoginActivityTest.kt # android/engine/src/test/java/org/smartregister/fhircore/engine/ui/login/LoginViewModelTest.kt
- Write helper a method to fetch all the practitioner-related resources.
maimoonak
reviewed
Jan 7, 2022
maimoonak
reviewed
Jan 7, 2022
android/engine/src/main/java/org/smartregister/fhircore/engine/auth/AccountAuthenticator.kt
Outdated
Show resolved
Hide resolved
maimoonak
reviewed
Jan 7, 2022
android/engine/src/main/java/org/smartregister/fhircore/engine/auth/AccountAuthenticator.kt
Outdated
Show resolved
Hide resolved
maimoonak
reviewed
Jan 7, 2022
...rc/main/java/org/smartregister/fhircore/engine/data/remote/model/response/ChildTreeNode.java
Outdated
Show resolved
Hide resolved
maimoonak
reviewed
Jan 7, 2022
...e/src/main/java/org/smartregister/fhircore/engine/data/remote/model/response/UserResponse.kt
Outdated
Show resolved
Hide resolved
maimoonak
reviewed
Jan 7, 2022
android/engine/src/main/java/org/smartregister/fhircore/engine/ui/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
maimoonak
reviewed
Jan 7, 2022
android/engine/src/main/java/org/smartregister/fhircore/engine/util/Constants.java
Outdated
Show resolved
Hide resolved
maimoonak
reviewed
Jan 7, 2022
android/engine/src/main/java/org/smartregister/fhircore/engine/util/KeyclockUtils.kt
Outdated
Show resolved
Hide resolved
maimoonak
reviewed
Jan 7, 2022
android/engine/src/main/java/org/smartregister/fhircore/engine/util/SharedPrefConstants.kt
Outdated
Show resolved
Hide resolved
dubdabasoduba
requested changes
Aug 17, 2022
android/engine/src/main/java/org/smartregister/fhircore/engine/auth/AccountAuthenticator.kt
Outdated
Show resolved
Hide resolved
...id/engine/src/main/java/org/smartregister/fhircore/engine/configuration/app/ConfigService.kt
Outdated
Show resolved
Hide resolved
We discussed to save the IDs directly into the SharedPreference, this helps us to avoid too many searches when using Parameters resource. Refer to this discussion #857 (comment)
FikriMilano
force-pushed
the
857_practitioner_details
branch
from
fbbe7e4 to
a4248d7
Compare
FikriMilano
changed the title
This was referenced Aug 23, 2022
Merged
dubdabasoduba
previously approved these changes
Aug 24, 2022
ellykits
requested changes
Aug 24, 2022
android/engine/src/main/java/org/smartregister/fhircore/engine/ui/login/LoginViewModel.kt
Show resolved
Hide resolved
android/engine/src/main/java/org/smartregister/fhircore/engine/util/PractitionerDetailsUtil.kt
Outdated
Show resolved
Hide resolved
ellykits
approved these changes
Aug 24, 2022
dubdabasoduba
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #857
Type
Choose one: Feature
Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guide