Refactor Practitioner Details Location fetch

- Refactor to fetch location by ids instead of identifiers
opensrp · Sep 6, 2023 · c3716b9 · c3716b9
1 parent 180083f
commit c3716b9
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 9 deletions.
diff --git a/configuration/pom.xml b/configuration/pom.xml
@@ -5,7 +5,7 @@
 <parent>
 	<groupId>org.smartregister</groupId>
 	<artifactId>hapi-fhir-opensrp-extensions</artifactId>
-	<version>0.0.22-SNAPSHOT</version>
+	<version>0.0.23-SNAPSHOT</version>
 </parent>
 <groupId>org.smartregister.hapi-fhir-opensrp-extensions</groupId>
 <artifactId>configuration</artifactId>

diff --git a/location/pom.xml b/location/pom.xml
@@ -4,7 +4,7 @@
 	<parent>
 		<artifactId>hapi-fhir-opensrp-extensions</artifactId>
 		<groupId>org.smartregister</groupId>
-		<version>0.0.22-SNAPSHOT</version>
+		<version>0.0.23-SNAPSHOT</version>
 	</parent>
 
 	<description>The repository holds the location extensions on the HAPI server</description>

diff --git a/pom.xml b/pom.xml
@@ -5,7 +5,7 @@
 	<groupId>org.smartregister</groupId>
 	<artifactId>hapi-fhir-opensrp-extensions</artifactId>
 	<packaging>pom</packaging>
-	<version>0.0.22-SNAPSHOT</version>
+	<version>0.0.23-SNAPSHOT</version>
 	<name>HAPI FHIR OpenSRP Extensions</name>
 	<description>This repository holds all the code extensions on top of Hapi-FHIR</description>
 	<url>https://github.com/opensrp/hapi-fhir-opensrp-extensions</url>

diff --git a/practitioner/pom.xml b/practitioner/pom.xml
@@ -4,15 +4,15 @@
 	<parent>
 		<artifactId>hapi-fhir-opensrp-extensions</artifactId>
 		<groupId>org.smartregister</groupId>
-		<version>0.0.22-SNAPSHOT</version>
+		<version>0.0.23-SNAPSHOT</version>
 	</parent>
 
 	<description>The repository holds the practitioner details extensions on the HAPI server</description>
 	<groupId>org.smartregister.hapi-fhir-opensrp-extensions</groupId>
 	<name>HAPI FHIR OpenSRP Extensions (Practitioner)</name>
 	<packaging>jar</packaging>
 	<url>https://github.com/opensrp/hapi-fhir-opensrp-extensions</url>
-	<version>0.0.12-SNAPSHOT</version>
+	<version>0.0.13-SNAPSHOT</version>
 	<artifactId>practitioner</artifactId>
 
 	<properties>

diff --git a/...r/src/main/java/org/smartregister/extension/rest/PractitionerDetailsResourceProvider.java b/...r/src/main/java/org/smartregister/extension/rest/PractitionerDetailsResourceProvider.java
@@ -139,10 +139,7 @@ public PractitionerDetails getPractitionerDetails(
             List<String> locationsIdReferences =
                     getLocationIdentifiersByOrganizations(bothOrganizations);
             List<String> locationIds = getLocationIdsFromReferences(locationsIdReferences);
-            List<String> locationsIdentifiers = getLocationIdentifiersByIds(locationIds);
-            logger.info("Searching for location hierarchy list by locations identifiers");
-            List<LocationHierarchy> locationHierarchyList =
-                    getLocationsHierarchy(locationsIdentifiers);
+            List<LocationHierarchy> locationHierarchyList = getLocationsHierarchy(locationIds);
             fhirPractitionerDetails.setLocationHierarchyList(locationHierarchyList);
             logger.info("Searching for locations by ids");
             List<Location> locationsList = getLocationsByIds(locationIds);