Form configurability compatibility update #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove native-forms dependency and add client-core form config dependency
Fix failing RegisterFragmentPresenterTest
ekigamba
suggested changes
Jun 4, 2020
| @@ -33,6 +34,9 @@ protected void scheduleJobsPeriodically() { | |||
| SyncSettingsServiceJob | |||
| .scheduleJob(SyncSettingsServiceJob.TAG, TimeUnit.MINUTES.toMillis(BuildConfig.CLIENT_SETTINGS_SYNC_MINUTES), | |||
| getFlexValue(BuildConfig.CLIENT_SETTINGS_SYNC_MINUTES)); | |||
| DocumentConfigurationServiceJob | |||
| .scheduleJob(DocumentConfigurationServiceJob.TAG, TimeUnit.MINUTES.toMillis(BuildConfig.CLIENT_SETTINGS_SYNC_MINUTES), | |||
There was a problem hiding this comment.
Can you add the job to run immediately after login?? I'll see if I can direct you to the exact location
There was a problem hiding this comment.
@ekigamba In the LoginInteractor#scheduleJobsImmediately() ? 🤔
There was a problem hiding this comment.
@allan-allay Yea, I think that's it. Also add it to run when the sync button on the register is clicked
There was a problem hiding this comment.
Cool. Let me implement the changes
|
Complexity increasing per file
==============================
- reference-app/src/main/java/org/smartregister/anc/job/AncJobCreator.java 1
See the complete overview on Codacy |
Schedule immediately on login & on sync icon clicked
|
Code Climate has analyzed commit 48bdb6b and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicJsonFormActivityinstead ofJsonFormActivitySee #521 for details