vunerability upgrade PR #917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubdabasoduba
approved these changes
Nov 4, 2022
dubdabasoduba
requested changes
Nov 4, 2022
opensrp-anc/build.gradle
Outdated
Comment on lines
256
to
257
| implementation 'org.jeasy:easy-rules-core:3.4.0' | ||
| implementation 'org.jeasy:easy-rules-mvel:3.4.0' |
There was a problem hiding this comment.
@bonfaceshisakha pointed out that this needs to be version 4.0.0
…ensrp-client-anc into vunerability-upgrades
- Update jackson-dataformat-yaml to 2.14.0 to fix security vulnerabilities - Update native-form to fix MVEL rules not working for some forms such as registration forms
ekigamba
reviewed
Dec 19, 2022
| /** | ||
| * Created by Ephraim Kigamba - [email protected] on 22-11-2022. | ||
| */ | ||
| public class YamlRuleDefinitionReaderExt extends YamlRuleDefinitionReader { |
There was a problem hiding this comment.
This can be removed and we can use the one on native form
ekigamba
reviewed
Dec 19, 2022
| @@ -45,4 +49,36 @@ protected Facts initializeFacts(Facts facts) { | |||
| public boolean beforeEvaluate(Rule rule, Facts facts) { | |||
| return selectedRuleName != null && selectedRuleName.equals(rule.getName()); | |||
| } | |||
|
|
|||
| @Override | |||
| public void beforeExecute(Rule rule, Facts facts) { | |||
There was a problem hiding this comment.
We can possibly remove this and use what is on native form
ekigamba
reviewed
Dec 19, 2022
Comment on lines
58
to
84
| private final YamlRuleDefinitionReaderExt yamlRuleDefinitionReader = new YamlRuleDefinitionReaderExt(); | ||
| private final MVELRuleFactory mvelRuleFactory = new MVELRuleFactory(yamlRuleDefinitionReader); | ||
|
|
||
| public AncRulesEngineHelper(Context context) { | ||
| this.context = context; | ||
| this.inferentialRulesEngine = new InferenceRulesEngine(); | ||
| RulesEngineParameters parameters = new RulesEngineParameters().skipOnFirstAppliedRule(true); | ||
| this.defaultRulesEngine = new DefaultRulesEngine(parameters); | ||
| /* ((DefaultRulesEngine) this.defaultRulesEngine).registerRuleListener(new RuleListener() { | ||
| @Override | ||
| public void beforeExecute(Rule rule, Facts facts) { | ||
| Timber.e("Putting facts in beforeExecute"); | ||
| facts.put("facts", facts); | ||
| } | ||
|
|
||
| @Override | ||
| public void onSuccess(Rule rule, Facts facts) { | ||
| Timber.e("Putting facts in onSuccess"); | ||
| facts.remove("facts"); | ||
| } | ||
|
|
||
| @Override | ||
| public void onFailure(Rule rule, Facts facts, Exception exception) { | ||
| Timber.e("Putting facts in onFailure"); | ||
| facts.remove("facts"); | ||
| } | ||
| });*/ |
There was a problem hiding this comment.
We can discard these changes
…showing the overview and previous contacts in the contacts sections
…showing the overview and previous contacts in the contacts sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.