Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update relevance for informant details and official details in death … #2057

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

DebbieArita
Copy link

…certification form

@DebbieArita DebbieArita linked an issue May 18, 2022 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@allan-on allan-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at and fix the issue in the comment

name: step1_informant_fields
description: informant_fields
priority: 1
condition: "step1_received_death_certificate('Yes') || step1_death_notification_done('Yes')"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be missing the comparison operation .equals() which breaks the relevance for the informant_fields step in the form.
The label currently doesn't show on the form. Please fix this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted.

@DebbieArita DebbieArita requested a review from allan-on May 19, 2022 07:24
@allan-on allan-on merged commit 5e19c77 into crvs-dev Jun 3, 2022
@allan-on allan-on deleted the 2050-crvs-update-death-certification branch June 3, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRVS: Revise informant details - options
2 participants