Compliance level #365
Merged
Compliance level #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennsimon
requested changes
Mar 18, 2021
| @@ -108,6 +124,7 @@ private void bindAutoCompleteText() { | |||
| autoCompleteTextView.setOnTouchListener(new View.OnTouchListener() { | |||
| public boolean onTouch(View v, MotionEvent event) { | |||
| ((InputMethodManager) (context).getSystemService(Context.INPUT_METHOD_SERVICE)).toggleSoftInput(InputMethodManager.SHOW_FORCED, InputMethodManager.HIDE_IMPLICIT_ONLY); | |||
| autoCompleteTextView.requestFocus(); | |||
There was a problem hiding this comment.
I think v.requestFocus() should work fine,
| @@ -191,7 +191,7 @@ android { | |||
| buildConfigField "int", "OPENMRS_UNIQUE_ID_BATCH_SIZE", '100' | |||
| buildConfigField "int", "OPENMRS_UNIQUE_ID_SOURCE", '2' | |||
| buildConfigField "int", "VACCINE_SYNC_TIME", '0' | |||
| buildConfigField "int", "DATABASE_VERSION", '13' | |||
| buildConfigField "int", "DATABASE_VERSION", '14' | |||
There was a problem hiding this comment.
Also add the change to other variants.
| @@ -190,6 +189,11 @@ public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) { | |||
| break; | |||
| case 13: | |||
| upgradeToVersion13CreateReasonForDefaultingTable(db); | |||
| break; | |||
| case 14: | |||
There was a problem hiding this comment.
I think you should add this to 13 because of #367
There was a problem hiding this comment.
So, I merge all the Migrations to 13 or Move 13 to 14 and Vice versa
Comment on lines
115
to
116
| Assert.assertNotNull(monthlyTally); | ||
| Assert.assertNotNull(view); |
| public void testOnBackActivity() { | ||
| View view = Mockito.mock(View.class); | ||
| activity.onBackActivity(); | ||
| Assert.assertNotNull(view); |
| activity.getDrawerLayoutId(); | ||
| Assert.assertNotNull(drawerLayout); | ||
| } | ||
|
|
||
| @Test | ||
| public void testOnRegistrationSaved() { | ||
| View view = Mockito.mock(View.class); | ||
| activity.onRegistrationSaved(true); | ||
| Assert.assertNotNull(view); |
| public void testGetDrawerLayoutIdd() { | ||
| DrawerLayout drawerLayout = Mockito.mock(DrawerLayout.class); | ||
| activity.getDrawerLayoutId(); | ||
| Assert.assertNotNull(drawerLayout); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue opensrp/opensrp-client-emmunize-malawi#9