Process skipped clients #506
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package org.smartregister.giz.job; | ||
|
|
||
| import android.content.Intent; | ||
|
|
||
| import androidx.annotation.NonNull; | ||
|
|
||
| import com.evernote.android.job.Job; | ||
|
|
||
| import org.jetbrains.annotations.NotNull; | ||
| import org.smartregister.AllConstants; | ||
| import org.smartregister.giz.service.ReProcessSyncIntentService; | ||
| import org.smartregister.job.BaseJob; | ||
|
|
||
| public class GIZClientReprocessJob extends BaseJob { | ||
|
|
||
| public static final String TAG = "GIZClientReprocessJob"; | ||
|
|
||
| @NonNull | ||
| @NotNull | ||
| @Override | ||
| protected Result onRunJob(@NonNull @NotNull Job.Params params) { | ||
| Intent intent = new Intent(getApplicationContext(), ReProcessSyncIntentService.class); | ||
| getApplicationContext().startService(intent); | ||
| return params != null && params.getExtras().getBoolean(AllConstants.INTENT_KEY.TO_RESCHEDULE, false) ? Result.RESCHEDULE : Result.SUCCESS; | ||
|
|
||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package org.smartregister.giz.recievers; | ||
|
|
||
| import android.content.BroadcastReceiver; | ||
| import android.content.Context; | ||
| import android.content.Intent; | ||
| import android.os.Bundle; | ||
|
|
||
| import org.smartregister.giz.job.GIZClientReprocessJob; | ||
|
|
||
| import timber.log.Timber; | ||
|
|
||
| import static org.smartregister.receiver.SyncStatusBroadcastReceiver.EXTRA_COMPLETE_STATUS; | ||
|
|
||
| public class GizReprocessSyncStatusReceiver extends BroadcastReceiver { | ||
| @Override | ||
| public void onReceive(Context context, Intent intent) { | ||
| Bundle data = intent.getExtras(); | ||
| if (data != null) { | ||
| boolean isComplete = data.getBoolean(EXTRA_COMPLETE_STATUS, false); | ||
| if (isComplete) { | ||
| GIZClientReprocessJob.scheduleJobImmediately(GIZClientReprocessJob.TAG); | ||
| Timber.d("Sync complete"); | ||
| } | ||
| } | ||
|
|
||
| Timber.d("broadcast Recieved"); | ||
|
There was a problem hiding this comment. I think the log is too vague and it would be easier to understand if it was a bit more specific on the broadcast that was received |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package org.smartregister.giz.service; | ||
|
|
||
| import android.app.IntentService; | ||
| import android.content.Intent; | ||
|
|
||
| import androidx.annotation.Nullable; | ||
|
|
||
| import org.smartregister.giz.application.GizMalawiApplication; | ||
|
|
||
| public class ReProcessSyncIntentService extends IntentService { | ||
|
|
||
| public static final String TAG = "ReProcessSyncIntentService"; | ||
|
|
||
| public ReProcessSyncIntentService() | ||
| { | ||
| super(TAG); | ||
| } | ||
|
|
||
| public ReProcessSyncIntentService(String name) { | ||
| super(name); | ||
| } | ||
|
|
||
| @Override | ||
| protected void onHandleIntent(@Nullable Intent intent) { | ||
| GizMalawiApplication.getInstance().gizEventRepository().processSkippedClients(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| package org.smartregister.giz.repository; | ||
|
|
||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.mockito.Mock; | ||
| import org.mockito.MockitoAnnotations; | ||
| import org.powermock.api.mockito.PowerMockito; | ||
| import org.powermock.core.classloader.annotations.PrepareForTest; | ||
| import org.powermock.modules.junit4.PowerMockRunner; | ||
| import org.smartregister.giz.util.GizUtils; | ||
| import org.smartregister.repository.Repository; | ||
| import org.smartregister.view.activity.DrishtiApplication; | ||
|
|
||
| import net.sqlcipher.Cursor; | ||
| import net.sqlcipher.database.SQLiteDatabase; | ||
| import java.util.HashSet; | ||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| @RunWith(PowerMockRunner.class) | ||
| @PrepareForTest({DrishtiApplication.class}) | ||
| public class GizEventRepositoryTest { | ||
|
|
||
| private GizEventRepository repository; | ||
| private static final String BASE_ENTITY_ID = "base_entity_id"; | ||
| private static final String EVENT_TYPE = "event_type"; | ||
| private static final String FORM_SUBMISSION_ID = "form_submission_id"; | ||
|
|
||
| @Mock | ||
| private SQLiteDatabase sqLiteDatabase; | ||
|
|
||
| @Mock | ||
| private GizUtils gizUtils; | ||
|
|
||
| @Mock | ||
| private Cursor cursor; | ||
|
|
||
| @Mock | ||
| private Repository baseRepository; | ||
|
|
||
| @Mock | ||
| private DrishtiApplication drishtiApplication; | ||
|
|
||
| @Before | ||
| public void setUp() { | ||
| repository = new GizEventRepository(); | ||
| MockitoAnnotations.initMocks(this); | ||
| PowerMockito.mockStatic(DrishtiApplication.class); | ||
| when(DrishtiApplication.getInstance()).thenReturn(drishtiApplication); | ||
| when(drishtiApplication.getRepository()).thenReturn(baseRepository); | ||
| when(baseRepository.getReadableDatabase()).thenReturn(sqLiteDatabase); | ||
| } | ||
|
|
||
| @Test | ||
| public void testHasEvent(){ | ||
| when(sqLiteDatabase.query( | ||
| "event", | ||
| new String[]{"baseEntityId"}, | ||
| "baseEntityId = ? and eventType = ? ", | ||
| new String[]{BASE_ENTITY_ID, EVENT_TYPE}, | ||
| null, | ||
| null, | ||
| null, | ||
| "1" | ||
| )).thenReturn(cursor); | ||
|
|
||
| when(cursor.getCount()).thenReturn(1); | ||
|
|
||
| boolean hasEvent = repository.hasEvent(BASE_ENTITY_ID, EVENT_TYPE); | ||
|
|
||
| assertTrue(hasEvent); | ||
| } | ||
|
|
||
|
|
||
|
|
||
| @Test | ||
| public void testAddFormSubmissionIds() { | ||
| when(baseRepository.getReadableDatabase()).thenReturn(sqLiteDatabase); | ||
| when(sqLiteDatabase.rawQuery("query", null)).thenReturn(cursor); | ||
| when(cursor.getCount()).thenReturn(1); | ||
| when(cursor.getColumnIndex("formSubmissionId")).thenReturn(0); | ||
| when(cursor.moveToFirst()).thenReturn(true); | ||
| when(cursor.getString(0)).thenReturn("formSubmissionId"); | ||
|
|
||
| HashSet<String> formSubmissionIds = new HashSet<>(); | ||
| repository.addFormSubmissionIds(formSubmissionIds, "query"); | ||
|
|
||
| assertFalse(formSubmissionIds.isEmpty()); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these services set as
exportedand why is this explicitly declared?