Fix reference and integration issues #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix errors in AvailableMapsFragment, LocationTaskIntentService & OfflineMapHelper - Add mapStyleAssetPath as the FileHttpServerTask constructor param
- Add AvailableOfflineMapsInteractor
- Add DownloadedOfflineMapsInteractor - Add RealmDatabase getter on TaskingLibrary
Change the modifier of the init method to static
- Require clients using the TaskingLibrary to implement the properties and behaviours
- The commented out functionality was delegated to the implementing application - The commented out functionality will be implemented on the TaskingLibraryConfiguration class methods
ekigamba
force-pushed
the
fix-reference-and-integration-issues
branch
from
e768942 to
39fa881
Compare
- Fix repository is null RuntimeException - Fix integration requirements by adding required params for implementation of features on the client app - Increment version to 0.0.3-SNAPSHOT
- Fixed some failing tests by adding assets to the tests folder - Fixed failing tests by implementing test activities & configurations - Fixed failing tests by verifying configuration methods were called instead of expected implementations on Reveal
1. Fix missing implementations - missing strings, missing variables set as null, server configs 2. Move other implementation to client app 3. Fix documentation on implementing abstract method getMapStyleAssetPath 4. Fix some tests by updating getActionDrawable(android.content.Context context, TaskDetails task) implementation
…ase call - Add RealmDatabase shadow - Add RealmDatabase shadow to Robolectric shadows config
githengi
previously approved these changes
Nov 4, 2020
githengi
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #19
To test
./gradlew clean && ./gradlew :opensrp-tasking:uploadArchives -PmavenLocal=true --stacktrace --rerun-tasksin the root folder of the project to publish the lib in your local maven repositoryls ~/.m2/repository/org/smartregister/opensrp-client-tasking/to confirm that the folder0.0.3-SNAPSHOTwas created & artifact publishedintegrate-tasking-librarybranch in this PRlocal.properties& run the project