Merge pull request #588 from opensrp/master-refactor-practitioner-sea…

…rch-bean

refactor practitioner search bean

pom.xml

@@ -5,7 +5,7 @@
 
 	<artifactId>opensrp-server-core</artifactId>
 	<packaging>jar</packaging>
-	<version>3.2.3-SNAPSHOT</version>
+	<version>3.2.4-SNAPSHOT</version>
 	<name>opensrp-server-core</name>
 	<description>OpenSRP Server Core module</description>
 	<url>https://github.com/OpenSRP/opensrp-server-core</url>

src/main/java/org/opensrp/search/BaseSearchBean.java

@@ -16,7 +16,7 @@ public enum OrderByType {
 	}
 
 	public enum FieldName {
-		id
+		id, server_version
 	}
 
 	private Integer pageNumber = 0;

src/main/java/org/opensrp/search/PractitionerSearchBean.java

@@ -10,12 +10,4 @@
 public class PractitionerSearchBean extends BaseSearchBean {
 
 	private Long serverVersion;
-
-	public Long getServerVersion() {
-		return serverVersion;
-	}
-
-	public void setServerVersion(Long serverVersion) {
-		this.serverVersion = serverVersion;
-	}
 }

src/test/java/org/opensrp/repository/postgres/PractitionerRepositoryTest.java

@@ -384,4 +384,17 @@ public void testCountAllPractitioners() {
         practitionerRepository.add(practitioner1);
         assertEquals(1, practitionerRepository.countAllPractitioners());
     }
+
+    @Test
+    public void testGetPractitionersByIdentifier() {
+        Practitioner expectedPractitioner = initTestPractitioner1();
+        practitionerRepository.add(expectedPractitioner);
+        Practitioner actualPractitioner = practitionerRepository.getPractitionerByIdentifier(expectedPractitioner.getIdentifier());
+        assertNotNull(actualPractitioner);
+        assertEquals(expectedPractitioner.getIdentifier(),actualPractitioner.getIdentifier());
+        assertEquals(expectedPractitioner.getName(),actualPractitioner.getName());
+        assertEquals(expectedPractitioner.getUserId(),actualPractitioner.getUserId());
+        assertEquals(expectedPractitioner.getUsername(),actualPractitioner.getUsername());
+    }
+
 }