-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Yoga] Add Octavia volume-based Amphora test #1280
Merged
brianphaley
merged 3 commits into
openstack-charmers:stable/yoga
from
dosaboy:octavia-volume-backend-amphora-yoga
Oct 29, 2024
Merged
[Yoga] Add Octavia volume-based Amphora test #1280
brianphaley
merged 3 commits into
openstack-charmers:stable/yoga
from
dosaboy:octavia-volume-backend-amphora-yoga
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosaboy
changed the title
Add Octavia volume-based Amphora test
[yoga] Add Octavia volume-based Amphora test
Oct 16, 2024
dosaboy
changed the title
[yoga] Add Octavia volume-based Amphora test
[Yoga] Add Octavia volume-based Amphora test
Oct 16, 2024
(cherry picked from commit cabe300)
Enable Amphora to run instances booted from volume by flipping the config option `enable-volume-based-amphora` to True and checking volumes attached to the amphora instances. Depends-On: https://review.opendev.org/c/openstack/charm-octavia/+/931587 Related-Bug: https://launchpad.net/bugs/1901732 (cherry picked from commit d096096)
dosaboy
force-pushed
the
octavia-volume-backend-amphora-yoga
branch
from
October 17, 2024 12:03
cabe300
to
f0f60a5
Compare
The CompareOpenStack class allows the comparison of OpenStack codenames. (cherry picked from commit 7205e31)
dosaboy
force-pushed
the
octavia-volume-backend-amphora-yoga
branch
from
October 17, 2024 15:58
7561d56
to
f2ef3ac
Compare
nicolasbock
approved these changes
Oct 21, 2024
nicolasbock
approved these changes
Oct 29, 2024
brianphaley
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a cherry-pick you can probably ignore my comments
openstack-mirroring
pushed a commit
to openstack/charm-octavia
that referenced
this pull request
Oct 29, 2024
By default launched amphora will use ephemeral storage as defined by flavor used, this is suboptimal for environments where live-migration is desired (and avoiding the transfer of the blockstorage is needed), but also provides some resiliency in case of hypervisor failures. This patch adds a new set of configuration option to enable amphora instances booted from volume. * enable-volume-based-amphora * volume-size * volume-type More details about this feature can be found at https://opendev.org/openstack/octavia/commit/93b509cfe5ccced92ab482fa789ed6cdb700f154 Func-Test-Pr: openstack-charmers/zaza-openstack-tests#1280 Closes-Bug: #1901732 Change-Id: I45a8385e3522f161e31daf786f293777363e57e0 (cherry picked from commit a4711f5) (cherry picked from commit 75710ff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Amphora to run instances booted from
volume by flipping the config option
enable-volume-based-amphora
to True andchecking volumes attached to the amphora
instances.
Depends-On: https://review.opendev.org/c/openstack/charm-octavia/+/931587
Related-Bug: https://launchpad.net/bugs/1901732