Adding initial support for Eviden Trustway HSM #162
+355
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mauricioharley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vakwetu
requested changes
Sep 20, 2024
|
/retest |
Signed-off-by: Mauricio Harley <[email protected]>
mauricioharley
changed the title
mauricioharley
changed the title
added 2 commits
October 1, 2024 13:31
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
dmendiza
reviewed
Oct 1, 2024
| @@ -35,6 +35,10 @@ spec: | |||
| spec: | |||
| description: BarbicanAPISpec defines the desired state of BarbicanAPI | |||
| properties: | |||
| clientCertificate: | |||
There was a problem hiding this comment.
Maybe we should consider grouping these into their own key. e.g.
spec:
...
properties:
pkcs11:
clientCertificate: $CERT_CONTENTS_HERE
There was a problem hiding this comment.
Got it. $CERT_CONTENTS_HERE will receive the OpenShift secret name that actually stores the certificate.
This file was automatically generated by a pre-commit hook. I'll check how this could be translated into the specification file.
vakwetu
requested changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell script automates the necessary steps to include Eviden's Trustway HSM (Hardware Security Module) client software into the container images for Barbican API and Barbican Worker.
The code is the initial support spec to include the same vendor and product.