Functional tests for HSM Support #190
Open
+1,660
−1,317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mauricioharley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
added 2 commits
December 2, 2024 19:37
hold-the-node Signed-off-by: Mauricio Harley <[email protected]> Co-authored-by: Ade Lee <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
xek
force-pushed
the
luna_functional_tests
branch
from
6d5561c to
19dd70c
Compare
gibizer
previously requested changes
Dec 3, 2024
gibizer
reviewed
Dec 3, 2024
Signed-off-by: Mauricio Harley <[email protected]>
mauricioharley
force-pushed
the
luna_functional_tests
branch
from
19dd70c to
dca4e9b
Compare
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
mauricioharley
force-pushed
the
luna_functional_tests
branch
from
be9984d to
9cb2c87
Compare
Signed-off-by: Mauricio Harley <[email protected]>
mauricioharley
force-pushed
the
luna_functional_tests
branch
from
9cb2c87 to
8c4c86f
Compare
|
/retest |
1 similar comment
|
/retest |
vakwetu
reviewed
Dec 17, 2024
vakwetu
reviewed
Dec 17, 2024
vakwetu
reviewed
Dec 17, 2024
vakwetu
reviewed
Dec 17, 2024
vakwetu
reviewed
Dec 17, 2024
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
bump controller tools to the version which bumps k8s deps to v0.29.0, which aligns with the version in the operators. Signed-off-by: Martin Schuppert <[email protected]>
If the 'git show BASE_REF' fails assume it is a net new CRD and should be fine. Signed-off-by: Martin Schuppert <[email protected]>
|
recheck |
Signed-off-by: Mauricio Harley <[email protected]>
mauricioharley
force-pushed
the
luna_functional_tests
branch
from
981c02e to
e600c2d
Compare
vakwetu
reviewed
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional tests for the Luna HSM model support.