Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert adoption_vars.yaml to latest revision working for hci adoption #2650

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revert adoption_vars.yaml to latest revision working for hci adoption #2650

wants to merge 1 commit into from

Conversation

ciecierski
Copy link
Contributor

@ciecierski ciecierski commented Jan 15, 2025 •
edited by openshift-ci bot
Loading

In https://github.com/openstack-k8s-operators/ci-framework/pull/2548/files we loop over networks and as a result all networks have defaultRoute key set to true.

Revert to temporary fix: OSPRH-13013

@ciecierski ciecierski requested a review from a team as a code owner January 15, 2025 22:20
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign evallesp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft January 15, 2025 22:20
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@ciecierski ciecierski requested a review from hjensas January 15, 2025 22:22
@ciecierski
Copy link
Contributor Author

@hjensas Have you seen the problem openstackdataplanenodeset web hook error as described in linked jira issue in alpha job?

@ciecierski
Revert adoption_vars.yaml to latest revision working for hci adoption
6308156 
In https://github.com/openstack-k8s-operators/ci-framework/pull/2548/files we loop
over networks and networks have defaultRoute key set to true

Revert to temporary fix: OSPRH-13013
@ciecierski ciecierski force-pushed the adoption-vars-revert branch from b445b2a to 6308156 Compare January 15, 2025 22:45
@hjensas
Copy link
Contributor

hjensas commented Jan 16, 2025 •
edited by openshift-ci bot
Loading

@hjensas Have you seen the problem openstackdataplanenodeset web hook error as described in linked jira issue in alpha job?

No, we never got to the stage where dataplane deployment started. We have been focusing on the ironic part of testing - and there is no need for a dataplane to test that ...

I introduced a bug there, but I think #2653 will fix OSPRH-13013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjensas hjensas Awaiting requested review from hjensas

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ciecierski @hjensas