Skip to content

Commit

Permalink
Adds os_cloud_name variable for development_environment role
Browse files Browse the repository at this point in the history
As part of [1] this adds a new os_cloud_name var for the
development_environment role to be used with the prelaunch vm test
instance creation. This retains current behaviour OS_CLOUD=standalone.
Needed by [2].

https://issues.redhat.com/browse/OSPRH-5754

[1] https://issues.redhat.com/browse/OSPRH-3038
[2] https://review.rdoproject.org/r/c/rdo-jobs/+/52452
  • Loading branch information
marios committed Apr 17, 2024
1 parent 6209f6b commit 52bd789
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/roles/dataplane_adoption/defaults/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ default_timesync_ntp_servers:
edpm_node_hostname: standalone.localdomain
edpm_user: root
edpm_nodes:
standalone:
"{{ edpm_node_hostname | default('standalone') }}":
hostName: "{{ edpm_node_hostname }}"
ansible:
ansibleHost: "{{ edpm_node_ip }}"
Expand Down
1 change: 1 addition & 0 deletions tests/roles/development_environment/defaults/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ prelaunch_test_instance: true
prelaunch_test_instance_script: pre_launch.bash
edpm_privatekey_path: ~/install_yamls/out/edpm/ansibleee-ssh-key-id_rsa
run_pre_adoption_validation: true
os_cloud_name: standalone
2 changes: 1 addition & 1 deletion tests/roles/development_environment/tasks/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
EDPM_PRIVATEKEY_PATH: "{{ edpm_privatekey_path }}"
ansible.builtin.shell:
cmd: |
alias openstack="ssh -i {{ edpm_privatekey_path }} root@{{ edpm_node_ip }} OS_CLOUD=standalone openstack"
alias openstack="ssh -i {{ edpm_privatekey_path }} root@{{ standalone_ip | default(edpm_node_ip) }} OS_CLOUD={{ os_cloud_name }} openstack"
{{ lookup('ansible.builtin.file', prelaunch_test_instance_script) }}

0 comments on commit 52bd789

Please sign in to comment.