Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS Everywhere adoption #331

Merged
merged 30 commits into from
Apr 19, 2024
Merged

TLS Everywhere adoption #331

merged 30 commits into from
Apr 19, 2024

Conversation

xek
Copy link
Contributor

@xek xek commented Mar 6, 2024 •
edited by fao89
Loading

No description provided.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3a8e586717924a0295d975f005423dfd

❌ adoption-docs-preview FAILURE in 1m 43s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0f209d718136474aae80b618d5097e16

❌ data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 27m 48s
✔️ adoption-docs-preview SUCCESS in 1m 50s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/data-plane-adoption for 331,7532020543332f8f072b7cf5486a431508695e45

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/data-plane-adoption for 331,be9661b17f3da3aad90357e44434d16f012f5724

@olliewalsh olliewalsh requested review from stuggi and Deydra71 March 13, 2024 15:50
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/data-plane-adoption for 331,430df75ca15561fcd42f258ff480d19cbe914154

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/data-plane-adoption for 331,38fa91b83efed443dbd8ac499c4434f3db7d9299

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/data-plane-adoption for 331,2c4f5019e02f0400f0ffc0ab206bde7aa401ba49

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/data-plane-adoption for 331,6cac6cb07f187dddbf1dd23087c978788eaf411b

@xek xek changed the title TLS Everywhere adoption documentation TLS Everywhere adoption Mar 20, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/data-plane-adoption for 331,394252b0722e54d08d6a88fd3a9df6469d17aa92

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e2e72259c3104f6eb183aed4c85fd872

❌ data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 30m 16s
✔️ adoption-docs-preview SUCCESS in 1m 36s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/319ad9dc86a2475f88b0faa4ca4c2350

❌ data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 3h 11m 17s
✔️ adoption-docs-preview SUCCESS in 2m 28s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/19a438d58be04d2cbc6bcf536faf9f93

❌ data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 1h 28m 04s
✔️ adoption-docs-preview SUCCESS in 1m 54s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7204fc8c762948c9b88251f9ecdf0508

❌ data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 23m 59s
✔️ adoption-docs-preview SUCCESS in 1m 36s

vakwetu and others added 14 commits April 19, 2024 09:39
@vakwetu @xek
Reapply review comment changes
2087076 
Somehow changes made by mharley and afaranha for review comments ot
dropped in the rebase.  Reapplying these changes.
@xek
Update OVN user documentation with TLS-e
10653e1
@xek
Test stopping certmonger
695f665
@xek
Disable TLS-E by default
c13cb2a 
TLS-E will be enabled in rdo-jobs.

This change also contains fixes for running the tests
without TLS Everywhere.
@xek
Add note about the need to restart
700f0df
@xek @fao89
Fix failure when enable_tlse is not defined
0d720d9 
Co-authored-by: Fabricio Aguiar <[email protected]>
@xek
Fall back to standalone.localdomain
b5be0c1 
Introduce the edpm_node_hostname, so that the standalone hostname
can be changed in the CI job definition.
@afaranha @xek
Update doc to run env with TLS enabled
339602e
@xek
Add missing variable computes
41c8f9e
@xek
Add customIssuer to documentation
4ace621 
This allows to override the configuration with a custom CA.
@xek
Update the ToC and TLS section
f45d2d9 
This updates the TLS-E documentation adjusting the headers
and updating it with what is actually tested.
@xek
Add dataplane tls configuration
b6ac7fb
@afaranha @xek
Update 'Stop and disable certmonger' script
0c64ab6
@xek
Minor documentation wording adjustements
9244ea3
@jistr
Copy link
Contributor

jistr commented Apr 19, 2024

@xek ok to merge this one and iterate?

@xek
Copy link
Contributor Author

xek commented Apr 19, 2024

@jistr yep, go ahead

@jistr jistr merged commit a53f7ff into openstack-k8s-operators:main Apr 19, 2024
3 checks passed
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 22, 2024
@xek @karelyatin
Enable TLS Everywhere testing
ae9a2fe 
Depends-On: openstack-k8s-operators/install_yamls#756
Depends-On: openstack-k8s-operators/data-plane-adoption#331
Change-Id: Id40199097d46ba19b12b79577ace599c97674441
@marios
Copy link
Contributor

marios commented Apr 23, 2024

this one broke the periodic job - see the last three builds [1] [2] [3]

TASK [backend_services : run kustomize and create controlplane with container overrides] ***
fatal: [localhost]: FAILED! => {"changed": true, "cmd": "set -euxo pipefail\n\n\nmkdir -p tmp\noc kustomize periodic_ci > tmp/test_deployment.yaml\noc apply -f tmp/test_deployment.yaml\n", "delta": "0:00:00.271966", "end": "2024-04-20 04:32:37.536389", "msg": "non-zero return code", "rc": 1, "start": "2024-04-20 04:32:37.264423", "stderr": "+ mkdir -p tmp\n+ oc kustomize periodic_ci\n# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.\n# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.\n# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.\nerror: trouble configuring builtin PatchStrategicMergeTransformer with config: `\npaths:\n- ../base/tls_overrides.yaml\n- container_image_overrides.yaml\n`: security; file '/home/zuul/src/github.com/openstack-k8s-operators/data-plane-adoption/tests/config/base/tls_overrides.yaml' is not in or below '/home/zuul/src/github.com/openstack-k8s-operators/data-plane-adoption/tests/config/periodic_ci'", "stderr_lines": ["+ mkdir -p tmp", "+ oc kustomize periodic_ci", "# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.", "# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.", "# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.", "error: trouble configuring builtin PatchStrategicMergeTransformer with config: `", "paths:", "- ../base/tls_overrides.yaml", "- container_image_overrides.yaml", "`: security; file '/home/zuul/src/github.com/openstack-k8s-operators/data-plane-adoption/tests/config/base/tls_overrides.yaml' is not in or below '/home/zuul/src/github.com/openstack-k8s-operators/data-plane-adoption/tests/config/periodic_ci'"], "stdout": "", "stdout_lines": []}

The patch at #415 for the 'wrong content' cix will also fix this though.

Moving forward lets try to sanity check the periodic/downstream jobs are not broken by these large changes that have a good chance of disruption. cc @jistr @cescgina

[1] https://review.rdoproject.org/zuul/build/d60664b9729a48eaa46fb51e349763de
[2] https://review.rdoproject.org/zuul/build/b257531465f248d1b7dcec2c7ec95d5c
[3] https://review.rdoproject.org/zuul/build/a6dfceebb7574ddeb9af35d9bc9e0370

@marios marios mentioned this pull request Apr 23, 2024
Merged
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 23, 2024
@xek @karelyatin
Enable TLS Everywhere testing
ca2af9a 
Depends-On: openstack-k8s-operators/install_yamls#756
Depends-On: openstack-k8s-operators/data-plane-adoption#331
Change-Id: Id40199097d46ba19b12b79577ace599c97674441
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 6, 2024
@xek
Enable TLS Everywhere testing
575b523 
Depends-On: openstack-k8s-operators/install_yamls#756
Depends-On: openstack-k8s-operators/data-plane-adoption#331
Change-Id: Id40199097d46ba19b12b79577ace599c97674441
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 7, 2024
@xek
Enable TLS Everywhere testing
1ae1736 
Depends-On: openstack-k8s-operators/install_yamls#756
Depends-On: openstack-k8s-operators/data-plane-adoption#331
Change-Id: Id40199097d46ba19b12b79577ace599c97674441
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 8, 2024
@xek
Enable TLS Everywhere testing
f9f5d4c 
Depends-On: openstack-k8s-operators/install_yamls#756
Depends-On: openstack-k8s-operators/data-plane-adoption#331
Change-Id: Id40199097d46ba19b12b79577ace599c97674441
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 9, 2024
@xek
Enable TLS Everywhere testing
86ad3d7 
Depends-On: openstack-k8s-operators/install_yamls#756
Depends-On: openstack-k8s-operators/data-plane-adoption#331
Change-Id: Id40199097d46ba19b12b79577ace599c97674441
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 9, 2024
@xek
Enable TLS everywhere for data plane adoption no-ceph standalone job
ffacd68 
This doesn't enable TLS everywhere testing for the Ceph job,
since we don't need to test with Ceph. We also still want to
test the case without TLS.

Depends-On: openstack-k8s-operators/install_yamls#756
Depends-On: openstack-k8s-operators/data-plane-adoption#331
Change-Id: Id40199097d46ba19b12b79577ace599c97674441
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 9, 2024
@xek
Enable TLS everywhere for data plane adoption no-ceph standalone job
962931a 
This doesn't enable TLS everywhere testing for the Ceph job,
since we don't need to test with Ceph. We also still want to
test the case without TLS.

Depends-On: openstack-k8s-operators/install_yamls#756
Depends-On: openstack-k8s-operators/data-plane-adoption#331
Change-Id: Id40199097d46ba19b12b79577ace599c97674441
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 14, 2024
@xek
Enable TLS everywhere for data plane adoption no-ceph standalone job
528ab47 
This doesn't enable TLS everywhere testing for the Ceph job,
since we don't need to test with Ceph. We also still want to
test the case without TLS.

Depends-On: openstack-k8s-operators/install_yamls#756
Depends-On: openstack-k8s-operators/data-plane-adoption#331
Change-Id: Id40199097d46ba19b12b79577ace599c97674441
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 15, 2024
@xek
Enable TLS everywhere for data plane adoption no-ceph standalone job
25a1015 
This doesn't enable TLS everywhere testing for the Ceph job,
since we don't need to test with Ceph. We also still want to
test the case without TLS.

Depends-On: openstack-k8s-operators/install_yamls#756
Depends-On: openstack-k8s-operators/data-plane-adoption#331
Change-Id: Id40199097d46ba19b12b79577ace599c97674441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afaranha afaranha afaranha left review comments

@mauricioharley mauricioharley mauricioharley left review comments

@stuggi stuggi stuggi left review comments

@jistr jistr jistr approved these changes

@olliewalsh olliewalsh olliewalsh left review comments

@klgill klgill klgill approved these changes

@Deydra71 Deydra71 Awaiting requested review from Deydra71

@vakwetu vakwetu Awaiting requested review from vakwetu

@fao89 fao89 Awaiting requested review from fao89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@xek @vakwetu @klgill @fao89 @jistr @marios @olliewalsh @stuggi @mauricioharley @afaranha