Beta docs restructuring c tl p lane services pt3 #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
FYI I'm going to push more changes today, and then the whole "control plane" chapter will be ready for review. |
klgill
force-pushed
the
BetaDocs-RestructuringCTlPLaneServicesPt3
branch
from
0b33826 to
f115653
Compare
|
@matbu Can you please review the new structure of the following os-diff files?
@hjensas Can you please review the new structure if the following ironic files?
|
|
@fmount Can you please review the new structure of the "Shared File System" files?
|
|
@klgill +2 on the |
fao89
approved these changes
Apr 11, 2024
fmount
approved these changes
Apr 11, 2024
gbrinn
reviewed
Apr 15, 2024
| Before starting the adoption workflow, pull the configuration from the {rhos_prev_long} services and {OpenStackPreviousInstaller} on your file system to back up the configuration files. You can then use the files later, during the configuration of the adopted services, and for the record to compare and make sure nothing has been missed or misconfigured. | ||
|
|
||
| Make sure you have pull the os-diff repository and configure according to your environment: | ||
| link:planning.md#Configuration tooling[Configure os-diff] |
There was a problem hiding this comment.
@matbu Should this "planning.md" link be included in the downstream docs?
And should this link be in the downstream docs? https://github.com/openstack-k8s-operators/os-diff/blob/main/config.yaml
CC: @jistr
gbrinn
reviewed
Apr 15, 2024
docs_user/modules/deploying-the-bare-metal-provisioning-service.adoc
Outdated
Show resolved
Hide resolved
klgill
commented
Apr 15, 2024
docs_user/modules/deploying-the-bare-metal-provisioning-service.adoc
Outdated
Show resolved
Hide resolved
klgill
force-pushed
the
BetaDocs-RestructuringCTlPLaneServicesPt3
branch
from
f115653 to
88a8a7d
Compare
hjensas
reviewed
Apr 17, 2024
docs_user/modules/con_bare-metal-provisioning-service-configurations.adoc
Outdated
Show resolved
Hide resolved
klgill
force-pushed
the
BetaDocs-RestructuringCTlPLaneServicesPt3
branch
from
88a8a7d to
68e2a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last batch of control plane services files.
Peer reviews, please use the checklist to stay in scope: https://docs.google.com/document/d/1hxKJdhGNqSOTg6WrbYjJaQIWDu7x5cl2QRYJ7G0HFt8/edit#heading=h.o8ezt27iw7kl