Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta docs restructure ceph migration rbd #407

Conversation

klgill
Copy link
Contributor

@klgill klgill commented Apr 16, 2024

Restructured Ceph RBD migration section.

Peer reviewers, please use the checklist to stay in scope: https://docs.google.com/document/d/1hxKJdhGNqSOTg6WrbYjJaQIWDu7x5cl2QRYJ7G0HFt8/edit#heading=h.o8ezt27iw7kl

@klgill
Copy link
Contributor Author

klgill commented Apr 16, 2024

@fmount I have questions in the following files:

  • assembly_migrating-ceph-rbd.adoc
  • proc_migrating-mon-and-mgr-from-controller-nodes.adoc

The questions are preceded by "//kgilliga:". Let me know if this is unclear.

@klgill klgill requested review from jistr, fao89 and fmount April 16, 2024 19:43
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general there's work to do in the RBD ceph procedure to make sure it reflects the new EDPM standard. I'll do this during Q2, but in the meantime improving the existing PoC and turn it into a procedure that can be followed would be a nice thing to do.

docs_user/assemblies/assembly_migrating-ceph-rbd.adoc Outdated Show resolved Hide resolved
docs_user/assemblies/assembly_migrating-ceph-rbd.adoc Outdated Show resolved Hide resolved
docs_user/assemblies/assembly_migrating-ceph-rbd.adoc Outdated Show resolved Hide resolved
docs_user/assemblies/assembly_migrating-ceph-rbd.adoc Outdated Show resolved Hide resolved
docs_user/assemblies/assembly_migrating-ceph-rbd.adoc Outdated Show resolved Hide resolved

= Migrating Ceph Monitor and Ceph Manager daemons to Red Hat Ceph Storage nodes
//kgilliga: I'm trying to understand the purpose of this procedure. Is this procedure a prescriptive way for customers to migrate Ceph Monitor and Ceph manager daemons from controller nodes to Red Hat Ceph Storage nodes? Or are we recommending that customers create a proof of concept before doing the actual migration? And are oc0-controller-1 and oc0-ceph-0 just examples of the names of nodes for the purposes of this procedure?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are just examples. this document was a PoC but we might want to revisit it and turn into a procedure. At the time of writing EDPM wasn't a thing, so we might want to revisit the TripleO part of it.
I'll follow up in the next few weeks.

with only mon, mgrs, and osds to simulate the environment a customer will be in
before starting the migration.
controller node, in terms of Red Hat Ceph Storage daemons, and move them to a different node.
The initial target of the POC is RBD only, which means you are going to move only mon and mgr daemons. For the purposes of this POC, you will deploy a Red Hat Ceph Storage cluster with only mon, mgrs, and osds to simulate the environment a customer will be in before starting the migration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can start removing the PoC wording, and I'll revisit the part of it to make sure it's consistent w/ what we currently have

The same approach and the same steps can be applied to migrate oc0-controller-2 to oc0-ceph-1.
//kgilliga: Are "oc0-controller-2 to oc0-ceph-1" generic names? Can we say something like: "Repeat this procedure for additional controller and Red Hat Ceph Storage nodes in your environment?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I would say that the same procedure should be repeated for the other controller nodes until all the mon/mgrs are migrated to the target nodes.

@rheslop
Copy link
Contributor

rheslop commented Apr 17, 2024

Hey Katie, based on the Adoption Peer Review Checklist for beta, this looks good to me.

@klgill klgill merged commit 186764b into openstack-k8s-operators:main Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants